Bug 159056 - Implement redirect support post CORS-preflight
Summary: Implement redirect support post CORS-preflight
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 151937
  Show dependency tree / graph
 
Reported: 2016-06-23 07:47 PDT by Anne van Kesteren
Modified: 2016-08-23 03:20 PDT (History)
8 users (show)

See Also:

Attachments
Patch (22.77 KB, patch)
2016-08-21 14:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2016-06-23 07:47:23 PDT 
A CORS-preflight can be followed by a redirect these days.

See also:
* https://bugzilla.mozilla.org/show_bug.cgi?id=918767
* https://bugs.chromium.org/p/chromium/issues/detail?id=580796
* https://github.com/w3c/web-platform-tests/issues/2520
Comment 1 youenn fablet 2016-08-21 14:07:38 PDT 
Created attachment 286571 [details]
Patch
Comment 2 Alex Christensen 2016-08-21 22:25:06 PDT 
Should this be r?
Comment 3 youenn fablet 2016-08-22 06:22:30 PDT 
Comment on attachment 286571 [details]
Patch

There is no test checking valid XHR preflighting after cross-origin redirections.
But the fetch API tests cover successful (and failing) preflighting after cross-origin redirections.
Since the code between fetch and XHR is common, this is probably sufficient.
Marking patch as r?.
Comment 4 youenn fablet 2016-08-22 06:49:21 PDT 
Made a PR to W3C WPT tests at https://github.com/w3c/web-platform-tests/pull/3523
Same tests as in the patch with some minor style tweaks.
Comment 5 WebKit Commit Bot 2016-08-23 03:20:21 PDT 
Comment on attachment 286571 [details]
Patch

Clearing flags on attachment: 286571

Committed r204795: <http://trac.webkit.org/changeset/204795>
Comment 6 WebKit Commit Bot 2016-08-23 03:20:26 PDT 
All reviewed patches have been landed.  Closing bug.