Bug 159035 - Move the WebKitLegacy Apple Pay code to the open source repository
Summary: Move the WebKitLegacy Apple Pay code to the open source repository
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-22 13:08 PDT by Anders Carlsson
Modified: 2016-06-27 22:36 PDT (History)
3 users (show)

See Also:


Attachments
Patch (19.80 KB, patch)
2016-06-22 13:09 PDT, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-06-22 13:08:57 PDT
Move the WebKitLegacy Apple Pay code to the open source repository
Comment 1 Anders Carlsson 2016-06-22 13:09:44 PDT
Created attachment 281865 [details]
Patch
Comment 2 WebKit Commit Bot 2016-06-22 13:10:24 PDT
Attachment 281865 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:51:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:41:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2016-06-22 13:37:37 PDT
Comment on attachment 281865 [details]
Patch

rs=me
Comment 4 Anders Carlsson 2016-06-22 13:38:28 PDT
Committed r202346: <http://trac.webkit.org/changeset/202346>
Comment 5 Simon Fraser (smfr) 2016-06-27 22:36:58 PDT
This broke the CMake build.