WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159035
Move the WebKitLegacy Apple Pay code to the open source repository
https://bugs.webkit.org/show_bug.cgi?id=159035
Summary
Move the WebKitLegacy Apple Pay code to the open source repository
Anders Carlsson
Reported
2016-06-22 13:08:57 PDT
Move the WebKitLegacy Apple Pay code to the open source repository
Attachments
Patch
(19.80 KB, patch)
2016-06-22 13:09 PDT
,
Anders Carlsson
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2016-06-22 13:09:44 PDT
Created
attachment 281865
[details]
Patch
WebKit Commit Bot
Comment 2
2016-06-22 13:10:24 PDT
Attachment 281865
[details]
did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.mm:51: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/mac/WebCoreSupport/WebPaymentCoordinatorClient.h:41: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3
2016-06-22 13:37:37 PDT
Comment on
attachment 281865
[details]
Patch rs=me
Anders Carlsson
Comment 4
2016-06-22 13:38:28 PDT
Committed
r202346
: <
http://trac.webkit.org/changeset/202346
>
Simon Fraser (smfr)
Comment 5
2016-06-27 22:36:58 PDT
This broke the CMake build.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug