RESOLVED FIXED159033
Only call sqlite3_initialize() when a SQLite database is actually being opened 
https://bugs.webkit.org/show_bug.cgi?id=159033
Summary Only call sqlite3_initialize() when a SQLite database is actually being opened
Chris Dumez
Reported 2016-06-22 12:26:26 PDT
Only call sqlite3_initialize() when a SQLite database is actually being opened instead of doing it unconditionally. Sqlite3_initialize() is currently called in the SQLiteDatabase constructor which gets called on WebContent process initialization because a DatabaseTracker is constructed on initialization and DatabaseTracker has a SQLiteDatabase data member.
Attachments
Patch (3.51 KB, patch)
2016-06-22 12:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-06-22 12:35:21 PDT
Created attachment 281860 [details] Patch
Alex Christensen
Comment 2 2016-06-22 22:01:18 PDT
Brady will have to review this. I have two questions: Is it ok to assume that open is always going to be the first call on a SQLiteDatabase? I think the answer is yes. Should we even have databases in the WebProcess?
WebKit Commit Bot
Comment 3 2016-06-23 09:03:31 PDT
Comment on attachment 281860 [details] Patch Clearing flags on attachment: 281860 Committed r202379: <http://trac.webkit.org/changeset/202379>
WebKit Commit Bot
Comment 4 2016-06-23 09:03:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.