Bug 159021 - [Win] Use Windows api function to find top level parent.
Summary: [Win] Use Windows api function to find top level parent.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-22 03:40 PDT by Per Arne Vollan
Modified: 2016-06-23 11:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2016-06-22 04:02 PDT, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-06-22 03:40:30 PDT 
We can delete the findTopLevelParent function, and instead use the Windows api function GetAncestor.
Comment 1 Per Arne Vollan 2016-06-22 04:02:56 PDT 
Created attachment 281835 [details]
Patch
Comment 2 Brent Fulgham 2016-06-22 08:41:24 PDT 
Comment on attachment 281835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281835&action=review

A very enthusiastic r+!  :-)

> Tools/ChangeLog:8
> +        Delete findTopLevelParent function, and use Win32 function GetAncestor instead.

Oh, very good!
Comment 3 Per Arne Vollan 2016-06-22 11:18:45 PDT 
(In reply to comment #2)
> Comment on attachment 281835 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281835&action=review
> 
> A very enthusiastic r+!  :-)
> 
> > Tools/ChangeLog:8
> > +        Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
> 
> Oh, very good!

Thanks for the review!
Comment 4 Per Arne Vollan 2016-06-22 23:45:37 PDT 
Committed r202369: <https://trac.webkit.org/changeset/202369>