Bug 158998 – Begin moving the Apple Pay code to the open source repository

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

moving the Apple Pay code to the open source repository

[Anders Carlsson]

Created attachment 281780 [details]
Patch

[WebKit Commit Bot]

Attachment 281780 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 281780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281780&action=review

> Source/WebCore/Modules/applepay/PaymentCoordinator.h:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.

Just 2015?

> Source/WebCore/Modules/applepay/PaymentCoordinator.h:50
> +    bool supportsVersion(unsigned version);
> +    bool canMakePayments();

const?

> Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:26
> +#pragma once

Is this what we do now?

[Anders Carlsson]

(In reply to comment #3)
> Comment on attachment 281780 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281780&action=review
> 
> > Source/WebCore/Modules/applepay/PaymentCoordinator.h:2
> > + * Copyright (C) 2015 Apple Inc. All rights reserved.
> 
> Just 2015?

No, 2016 as well. Thanks.

> 
> > Source/WebCore/Modules/applepay/PaymentCoordinator.h:50
> > +    bool supportsVersion(unsigned version);
> > +    bool canMakePayments();
> 
> const?

They call out to the client so I don't think we can use const.

> 
> > Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:26
> > +#pragma once
> 
> Is this what we do now?

https://lists.webkit.org/pipermail/webkit-dev/2016-March/028058.html

[Anders Carlsson]

Created attachment 281785 [details]
Patch

[WebKit Commit Bot]

Attachment 281785 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/cocoa/PaymentCocoa.mm:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinatorClient.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/Modules/applepay/PaymentCoordinator.h:51:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 281785 [details]
Patch

rs=me, but try not to comment anything out this time :)

[Anders Carlsson]

Committed r202298: <http://trac.webkit.org/changeset/202298>