Bug 158995 – Web Inspector: first heap snapshot taken when a page is reloaded happens before the reload navigation

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

This is not so useful. If we can tell that a reload was initiated, maybe we should skip the initial snapshot or do it on the "load" event or DOMContentLoaded event.

[Radar WebKit Bug Importer]

<rdar://problem/26923778>

[Joseph Pecoraro]

Created attachment 281873 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

As a by-product, this fixes console.profile/profileEnd while the inspector frontend is open. Previously a programmatic start would have caused the frontend to send Timeline.start() and trick the backend into thinking "enabledByFrontend" which would cause the console.profileEnd to not stop the recording.

Now, the frontend doesn't send any Agent.start on a programmatic start.
Now, the frontend doesn't send any Agent.stop on a programmatic stop.

Which reduces traffic and just makes sense.

[Blaze Burg]

Comment on attachment 281873 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281873&action=review

Having trouble reviewing in review tool as it doesn't apply cleanly any more.

> Source/WebCore/ChangeLog:13
> +        AutoCapture happens on the backend happens when it is enabled

This sentence doesn't make sense.

> Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js:119
> +    start(programmatic)

Can we call this initiatedByAPI or something, anything other than 'programmatic'?

[Blaze Burg]

Comment on attachment 281873 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281873&action=review

r=me

It would be nice to have a test for this, but unlikely to be worth it right now with the reload issues and other instability.

> Source/WebCore/ChangeLog:11
> +        until after the page does its first navigation.

s/does/commits/

> Source/WebCore/ChangeLog:38
> +        Update the auto capture phase progressions.

s/progressions/transitions

>> Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js:119
>> +    start(programmatic)
> 
> Can we call this initiatedByAPI or something, anything other than 'programmatic'?

EDIT: I guess we have introduced this naming into the protocol already, so never mind. Still, I think it's rather vague and we should avoid it if possible. I prefer the initiatedByUser / initiatedByAPI dichotomy, which is similar to WebKit's userGesture terminology.

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/202384>