Bug 158994 - CodeBlock::shrinkToFit is racy
Summary: CodeBlock::shrinkToFit is racy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-21 11:29 PDT by Saam Barati
Modified: 2016-06-21 13:14 PDT (History)
12 users (show)

See Also:


Attachments
patch (1.87 KB, patch)
2016-06-21 11:49 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (1.87 KB, patch)
2016-06-21 11:51 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-06-21 11:29:26 PDT
Let's say CodeBlock A is finalizing its baseline compile.
Let's say CodeBlock B is inlining A, and asks A for a result profile.
This happens as the finalizing step of the baseline compile calls shrinkToFit on its m_resultProfiles
field without grabbing lock. This leads to a bad time.
Comment 1 Saam Barati 2016-06-21 11:30:43 PDT
<rdar://problem/26920212>
Comment 2 Saam Barati 2016-06-21 11:49:05 PDT
Created attachment 281762 [details]
patch
Comment 3 Saam Barati 2016-06-21 11:51:36 PDT
Created attachment 281763 [details]
patch
Comment 4 WebKit Commit Bot 2016-06-21 13:14:10 PDT
Comment on attachment 281763 [details]
patch

Clearing flags on attachment: 281763

Committed r202288: <http://trac.webkit.org/changeset/202288>
Comment 5 WebKit Commit Bot 2016-06-21 13:14:15 PDT
All reviewed patches have been landed.  Closing bug.