Solve the confusion around blankURL() and isBlankURL() in URL

[John Wilander]

These two functions in URL are causing confusion:

const URL& blankURL()
{
    static NeverDestroyed<URL> staticBlankURL(ParsedURLString, "about:blank");
    return staticBlankURL;
}

bool URL::isBlankURL() const
{
    return protocolIs("about");
}

We should consolidate into one notion of a blank URL and make sure callers get what they are expecting. This might require a new isAboutURL() function or similar.

[Rob Buis]

Created attachment 351920 [details]
Patch

[Rob Buis]

Created attachment 351963 [details]
Patch

[John Wilander]

Comment on attachment 351963 [details]
Patch

Looks good to me.

[John Wilander]

CCing Dan Bates and Alex Christensen since Dan had opinions one about:blank previously and Alex wrote most of our URL logic.

[Alex Christensen]

Comment on attachment 351963 [details]
Patch

renaming will make it so we don't introduce more problems.

[WebKit Commit Bot]

Comment on attachment 351963 [details]
Patch

Clearing flags on attachment: 351963

Committed r237073: <https://trac.webkit.org/changeset/237073>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45233696>