RESOLVED FIXED 158987
Move shouldInheritSecurityOriginFromOwner() from URL to Document 
https://bugs.webkit.org/show_bug.cgi?id=158987
Summary Move shouldInheritSecurityOriginFromOwner() from URL to Document
John Wilander
Reported 2016-06-21 09:39:46 PDT
We should move shouldInheritSecurityOriginFromOwner from URL to SecurityOrigin to keep the URL class free of policy decisions and the notion of origins.
Attachments
Patch (4.82 KB, patch)
2016-07-08 12:11 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-07-08 12:10:51 PDT
I suggest that we move URL::shouldInheritSecurityOriginFromOwner() back to Document because it implements the origin inheritance policy for Document objects per section Origin of the HTML5 spec., <https://html.spec.whatwg.org/multipage/browsers.html#origin> (8 July 2016). This policy is only applicable to Documents.
Daniel Bates
Comment 2 2016-07-08 12:11:37 PDT
Created attachment 283186 [details] Patch
Daniel Bates
Comment 3 2016-07-08 12:17:10 PDT
Although Darin Adler suggested that in comment 22, bug 158855 that we move shouldInheritSecurityOriginFromOwner() to SecurityOrigin.h, I choose to move it to Document because the policy shouldInheritSecurityOriginFromOwner() implements is only applicable to Document objects by <https://html.spec.whatwg.org/multipage/browsers.html#origin> and this function is only used in Document.cpp (as expected given that it is only applicable to Document objects).
Alex Christensen
Comment 4 2016-07-08 12:18:02 PDT
It definitely shouldn't be in URL
Daniel Bates
Comment 5 2016-07-08 17:29:04 PDT
Comment on attachment 283186 [details] Patch Clearing flags on attachment: 283186 Committed r203013: <http://trac.webkit.org/changeset/203013>
Daniel Bates
Comment 6 2016-07-08 17:29:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.