Bug 158980 - [GStreamer] top/bottom black bars added needlessly in fullscreen
Summary: [GStreamer] top/bottom black bars added needlessly in fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-21 02:31 PDT by Philippe Normand
Modified: 2016-06-27 02:22 PDT (History)
3 users (show)

See Also:

Attachments
[GStreamer] Trigger video resize upon first sample rendering (2.62 KB, patch)
2016-06-21 02:34 PDT, Philippe Normand 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2016-06-21 02:31:12 PDT 
When playing a 1280x720 video fullscreen on a monitor with the same resolution we should see the video fullscreen without top/bottom black bars.

It seems this regression was added in r201076.
Comment 1 Philippe Normand 2016-06-21 02:34:28 PDT 
Created attachment 281725 [details]
[GStreamer] Trigger video resize upon first sample rendering

The natural video size calculation depends on the validity of the
current sample, so whenever the first sample reached the sink it's a
good idea to reflect this on the player which will update its natural
size accordingly.

Fixes an issue where black borders were added on top and bottom of
fullscreen video.
Comment 2 Philippe Normand 2016-06-27 02:22:38 PDT 
Committed r202482: <http://trac.webkit.org/changeset/202482>