Bug 158977 - [Mac] Inline some picture-in-picture code
Summary: [Mac] Inline some picture-in-picture code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-20 23:48 PDT by mitz
Modified: 2016-06-21 06:16 PDT (History)
6 users (show)

See Also:


Attachments
Inline the code (45.05 KB, patch)
2016-06-20 23:57 PDT, mitz
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-06-20 23:48:10 PDT
Patch forthcoming.
Comment 1 mitz 2016-06-20 23:57:21 PDT
Created attachment 281721 [details]
Inline the code
Comment 2 WebKit Commit Bot 2016-06-20 23:59:07 PDT
Attachment 281721 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:294:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:342:  The parameter name "playbackSessionModel" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2016-06-21 06:07:20 PDT
Comment on attachment 281721 [details]
Inline the code

View in context: https://bugs.webkit.org/attachment.cgi?id=281721&action=review

> Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:108
> +    WebCore::WebVideoFullscreenInterfaceMac* _webVideoFullscreenInterfaceMac;
> +
> +    NSSize _videoDimensions;
> +    BOOL _playing;
> +
> +    RetainPtr<PIPViewController> _pipViewController;
> +    RetainPtr<NSViewController> _videoViewContainerController;
> +    RetainPtr<WebVideoViewContainer> _videoViewContainer;
> +    PIPState _pipState;
> +    BOOL _didRequestExitingPIP;
> +    BOOL _exitingToStandardFullscreen;
> +    RetainPtr<NSWindow> _returningWindow;
> +    NSRect _returningRect;

Minor nits: I don't t think the blank lines add anything. I would prefer to have the BOOLs grouped at the end of the interface defn.
Comment 4 mitz 2016-06-21 06:16:10 PDT
(In reply to comment #3)
> Comment on attachment 281721 [details]
> Inline the code
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281721&action=review
> 
> > Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm:108
> > +    WebCore::WebVideoFullscreenInterfaceMac* _webVideoFullscreenInterfaceMac;
> > +
> > +    NSSize _videoDimensions;
> > +    BOOL _playing;
> > +
> > +    RetainPtr<PIPViewController> _pipViewController;
> > +    RetainPtr<NSViewController> _videoViewContainerController;
> > +    RetainPtr<WebVideoViewContainer> _videoViewContainer;
> > +    PIPState _pipState;
> > +    BOOL _didRequestExitingPIP;
> > +    BOOL _exitingToStandardFullscreen;
> > +    RetainPtr<NSWindow> _returningWindow;
> > +    NSRect _returningRect;
> 
> Minor nits: I don't t think the blank lines add anything. I would prefer to
> have the BOOLs grouped at the end of the interface defn.

Done.

Committed <http://trac.webkit.org/r202274>.