Bug 158970 - [iOS] Typing text into a text field or text area causes screen to scroll down (hiding text entry)
Summary: [iOS] Typing text into a text field or text area causes screen to scroll down...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 158969 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-06-20 18:52 PDT by Simon Fraser (smfr)
Modified: 2016-06-21 15:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.32 KB, patch)
2016-06-20 18:53 PDT, Simon Fraser (smfr) 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-06-20 18:52:14 PDT 
[iOS] Typing text into a text field or text area causes screen to scroll down (hiding text entry)
Comment 1 Simon Fraser (smfr) 2016-06-20 18:53:29 PDT 
Created attachment 281692 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-06-20 18:55:07 PDT 
*** Bug 158969 has been marked as a duplicate of this bug. ***
Comment 3 Ryosuke Niwa 2016-06-20 21:07:37 PDT 
Comment on attachment 281692 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281692&action=review

> Source/WebCore/editing/Editor.cpp:1210
> +                    SelectionRevealMode revealMode = SelectionRevealMode::Reveal;
> +#if PLATFORM(IOS)
> +                    revealMode = SelectionRevealMode::RevealUpToMainFrame;
> +#endif

Can we instead do #if PLATFORM(IOS) #else?  I think that'll make the semantics clear.
Also, we can use auto here.
Comment 4 Ryosuke Niwa 2016-06-20 21:09:41 PDT 
<rdar://problem/26805722>
Comment 5 Simon Fraser (smfr) 2016-06-21 15:20:59 PDT 
https://trac.webkit.org/r202295