Bug 158963 - run-javascriptcore-tests should have flag to skip mozilla tests
Summary: run-javascriptcore-tests should have flag to skip mozilla tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-20 18:01 PDT by Aakash Jain
Modified: 2016-06-21 11:27 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (3.70 KB, patch)
2016-06-20 18:06 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch (3.64 KB, patch)
2016-06-21 07:15 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Updated patch (3.65 KB, patch)
2016-06-21 08:03 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-06-20 18:01:29 PDT 
Currently mozilla stress tests always run, even if we pass "no-jsc-stress" flag. We should have a flag to skip these tests as well.
Comment 1 Aakash Jain 2016-06-20 18:06:48 PDT 
Created attachment 281688 [details]
Proposed patch
Comment 2 Aakash Jain 2016-06-20 18:20:51 PDT 
also see rdar://problem/25838924
Comment 3 Alexey Proskuryakov 2016-06-20 23:57:55 PDT 
Comment on attachment 281688 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281688&action=review

> Tools/Scripts/run-javascriptcore-tests:94
> +  --[no-]mozilla-stress-tests   Run (or don't run) the Mozilla stress tests (default: $mozillaStressTestsDefault)

Are we calling these "Mozilla stress tests", or "Mozilla tests"?
Comment 4 Filip Pizlo 2016-06-20 23:58:53 PDT 
Comment on attachment 281688 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281688&action=review

>> Tools/Scripts/run-javascriptcore-tests:94
>> +  --[no-]mozilla-stress-tests   Run (or don't run) the Mozilla stress tests (default: $mozillaStressTestsDefault)
> 
> Are we calling these "Mozilla stress tests", or "Mozilla tests"?

I would call them "Mozilla tests"
Comment 5 Aakash Jain 2016-06-21 07:15:29 PDT 
Created attachment 281742 [details]
Updated patch
Comment 6 Aakash Jain 2016-06-21 08:03:18 PDT 
Created attachment 281746 [details]
Updated patch
Comment 7 WebKit Commit Bot 2016-06-21 11:27:03 PDT 
Comment on attachment 281746 [details]
Updated patch

Clearing flags on attachment: 281746

Committed r202283: <http://trac.webkit.org/changeset/202283>
Comment 8 WebKit Commit Bot 2016-06-21 11:27:07 PDT 
All reviewed patches have been landed.  Closing bug.