Bug 158962 – LLInt doesn't throw stack exception overflow from parent frame

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

<rdar://problem/26902188>

[Saam Barati]

Created attachment 281689 [details]
patch

[Build Bot]

Comment on attachment 281689 [details]
patch

Attachment 281689 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1539234

New failing tests:
js/regress-141098.html
http/tests/misc/large-js-program.php

[Build Bot]

Created attachment 281694 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 281689 [details]
patch

Attachment 281689 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1539263

New failing tests:
js/regress-141098.html
http/tests/misc/large-js-program.php

[Build Bot]

Created attachment 281697 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 281689 [details]
patch

Attachment 281689 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1539266

New failing tests:
js/regress-141098.html

[Build Bot]

Created attachment 281698 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 281689 [details]
patch

Attachment 281689 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1539278

New failing tests:
js/regress-141098.html
http/tests/misc/large-js-program.php

[Build Bot]

Created attachment 281699 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Saam Barati]

Comment on attachment 281689 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281689&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:507
> +    LLINT_RETURN_TWO(pc, callerFrame);

Oops.
This should be:
LLINT_RETURN_TWO(pc, exec)

[Saam Barati]

Created attachment 281701 [details]
patch for landing

[Build Bot]

Comment on attachment 281701 [details]
patch for landing

Attachment 281701 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1539472

New failing tests:
http/tests/misc/large-js-program.php

[Build Bot]

Created attachment 281703 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 281701 [details]
patch for landing

Attachment 281701 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1539479

New failing tests:
http/tests/misc/large-js-program.php

[Build Bot]

Created attachment 281705 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 281701 [details]
patch for landing

Attachment 281701 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1539546

New failing tests:
http/tests/misc/large-js-program.php

[Build Bot]

Created attachment 281708 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Saam Barati]

Comment on attachment 281701 [details]
patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=281701&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:473
> +    if (!callerFrame)
> +        callerFrame = exec;

This code pattern is wrong. I used it from JITOperations.
It must also restore vmEntryFrame or we will end up in a state in the VM where topVMEntryFrame and topCallFrame are not consistent with each other.
I'm going to upload a patch that also fixes this pattern inside JITOperations.

[Saam Barati]

Created attachment 281759 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 281759 [details]
patch for landing

Clearing flags on attachment: 281759

Committed r202286: <http://trac.webkit.org/changeset/202286>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.