More changes (not sure if I'm going to become an editing expert as a result, but others' experience will get obsoleted for sure :-) ).
Some of the changes might be rather risky. Any mistakes found (or not) during reviewing would be an opportunity to impove our test coverage...
Created attachment 17122 [details]
Comment on attachment 17122 [details]
-int Node::maxOffset() const
+int Node::maxCharacterOffset() const
- return 1;
+ return 0;
Could this be pure virtual?
+ return (int)m_data.length();
I'd prefer a C++ style cast.
Committed revision 27690.
(In reply to comment #2)
> Could this be pure virtual?
I think it can not - if it were pure virtual, other subclasses would have to override it.
> I'd prefer a C++ style cast.