Bug 158949 – Adopt commitPriority to get rid of the 2 AVPL solution for PiP

• Status: REOPENED
• Component: Media

[Jeremy Jones]

Adopt commitPriority to get rid of the 2 AVPL solution for PiP

[Jeremy Jones]

rdar://problem/26867866

[Jeremy Jones]

Created attachment 281660 [details]
Patch

[Jeremy Jones]

Created attachment 281664 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 281664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281664&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:116
> +            [oldContext setCommitPriority:0];
> +            [newContext setCommitPriority:1];

Are these persistent on the context, or do they just affect the next commit?

[Jeremy Jones]

(In reply to comment #4)
> Comment on attachment 281664 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281664&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:116
> > +            [oldContext setCommitPriority:0];
> > +            [newContext setCommitPriority:1];
> 
> Are these persistent on the context, or do they just affect the next commit?

As far as I can tell they are persistent.

[WebKit Commit Bot]

Comment on attachment 281664 [details]
Patch

Rejecting attachment 281664 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 281664, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/1538621

[Jeremy Jones]

http://trac.webkit.org/changeset/202252

[Alexey Proskuryakov]

Rolling out (see rdar://problem/26867866 for details).

[WebKit Commit Bot]

Re-opened since this is blocked by bug 158974

[Jeremy Jones]

http://trac.webkit.org/changeset/202350