Bug 158934 - [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
Summary: [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-20 02:19 PDT by Per Arne Vollan
Modified: 2016-06-22 23:35 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.07 KB, patch)
2016-06-20 02:31 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (5.06 KB, patch)
2016-06-20 22:46 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-06-20 02:19:02 PDT
We need to implement a way to delete an indexed database.
Comment 1 Per Arne Vollan 2016-06-20 02:31:24 PDT
Created attachment 281640 [details]
Patch
Comment 2 Brent Fulgham 2016-06-20 09:13:28 PDT
Comment on attachment 281640 [details]
Patch

r=me
Comment 3 Per Arne Vollan 2016-06-20 11:41:25 PDT
(In reply to comment #2)
> Comment on attachment 281640 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 4 Per Arne Vollan 2016-06-20 22:46:02 PDT
Created attachment 281715 [details]
Patch
Comment 5 Per Arne Vollan 2016-06-22 06:07:58 PDT
(In reply to comment #4)
> Created attachment 281715 [details]
> Patch

To avoid changing the existing database interface, I created a new database interface with the new delete database method.
Comment 6 Brent Fulgham 2016-06-22 08:38:38 PDT
Comment on attachment 281715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281715&action=review

Thank you! r=me.

> Source/WebKit/win/Interfaces/IWebDatabaseManager.idl:72
> +}

It's so annoying to have to do this, but it will avoid breaking existing binary clients. :-)
Comment 7 Per Arne Vollan 2016-06-22 11:18:00 PDT
(In reply to comment #6)
> Comment on attachment 281715 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281715&action=review
> 
> Thank you! r=me.
> 
> > Source/WebKit/win/Interfaces/IWebDatabaseManager.idl:72
> > +}
> 
> It's so annoying to have to do this, but it will avoid breaking existing
> binary clients. :-)

Thanks for reviewing!
Comment 8 Per Arne Vollan 2016-06-22 23:35:30 PDT
Committed r202368: <https://trac.webkit.org/changeset/202368>