WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
158934
[Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=158934
Summary
[Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
Per Arne Vollan
Reported
2016-06-20 02:19:02 PDT
We need to implement a way to delete an indexed database.
Attachments
Patch
(4.07 KB, patch)
2016-06-20 02:31 PDT
,
Per Arne Vollan
no flags
Details
Formatted Diff
Diff
Patch
(5.06 KB, patch)
2016-06-20 22:46 PDT
,
Per Arne Vollan
bfulgham
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Per Arne Vollan
Comment 1
2016-06-20 02:31:24 PDT
Created
attachment 281640
[details]
Patch
Brent Fulgham
Comment 2
2016-06-20 09:13:28 PDT
Comment on
attachment 281640
[details]
Patch r=me
Per Arne Vollan
Comment 3
2016-06-20 11:41:25 PDT
(In reply to
comment #2
)
> Comment on
attachment 281640
[details]
> Patch > > r=me
Thanks for reviewing!
Per Arne Vollan
Comment 4
2016-06-20 22:46:02 PDT
Created
attachment 281715
[details]
Patch
Per Arne Vollan
Comment 5
2016-06-22 06:07:58 PDT
(In reply to
comment #4
)
> Created
attachment 281715
[details]
> Patch
To avoid changing the existing database interface, I created a new database interface with the new delete database method.
Brent Fulgham
Comment 6
2016-06-22 08:38:38 PDT
Comment on
attachment 281715
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=281715&action=review
Thank you! r=me.
> Source/WebKit/win/Interfaces/IWebDatabaseManager.idl:72 > +}
It's so annoying to have to do this, but it will avoid breaking existing binary clients. :-)
Per Arne Vollan
Comment 7
2016-06-22 11:18:00 PDT
(In reply to
comment #6
)
> Comment on
attachment 281715
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=281715&action=review
> > Thank you! r=me. > > > Source/WebKit/win/Interfaces/IWebDatabaseManager.idl:72 > > +} > > It's so annoying to have to do this, but it will avoid breaking existing > binary clients. :-)
Thanks for reviewing!
Per Arne Vollan
Comment 8
2016-06-22 23:35:30 PDT
Committed
r202368
: <
https://trac.webkit.org/changeset/202368
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug