RESOLVED FIXED Bug 158908
JSC::Symbol should be hash-consed 
https://bugs.webkit.org/show_bug.cgi?id=158908
Summary JSC::Symbol should be hash-consed
Filip Pizlo
Reported 2016-06-18 15:33:57 PDT
I just realized that it's not possible to pointer-compare symbols! This means that all symbol comparisons require dependent loads to get the Symbol's underlying uid. This is probably worth fixing. We would like symbol comparisons to not require loads. To do that, we need to make Symbol hash-consed on a per-VM basis.
Attachments
Patch (63.45 KB, patch)
2016-07-28 03:01 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (64.10 KB, patch)
2016-07-28 03:03 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (64.11 KB, patch)
2016-07-28 03:26 PDT, Yusuke Suzuki 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-06-19 22:15:25 PDT
It sounds nice when using symbols as enum values (And using symbols in switch / if-else chain).
Yusuke Suzuki
Comment 2 2016-07-28 03:01:43 PDT
Created attachment 284766 [details] Patch
Yusuke Suzuki
Comment 3 2016-07-28 03:03:50 PDT
Created attachment 284767 [details] Patch
Yusuke Suzuki
Comment 4 2016-07-28 03:26:58 PDT
Created attachment 284770 [details] Patch
Filip Pizlo
Comment 5 2016-07-28 10:56:58 PDT
Comment on attachment 284770 [details] Patch Nice!!
Yusuke Suzuki
Comment 6 2016-07-29 00:16:21 PDT
Committed r203895: <http://trac.webkit.org/changeset/203895>
Yusuke Suzuki
Comment 7 2016-07-29 01:00:46 PDT
Committed r203897: <http://trac.webkit.org/changeset/203897>
Note You need to log in before you can comment on or make changes to this bug.