Bug 158903 - Add test expectations for macOS Sierra
Summary: Add test expectations for macOS Sierra
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-17 23:15 PDT by Alexey Proskuryakov
Modified: 2016-06-19 17:17 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.65 MB, patch)
2016-06-17 23:25 PDT, Alexey Proskuryakov 		achristensen: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2016-06-17 23:15:02 PDT 
Add test expectations for macOS Sierra.
Comment 1 Alexey Proskuryakov 2016-06-17 23:25:22 PDT 
Created attachment 281608 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2016-06-17 23:28:52 PDT 
Sadly, looks like EWS is not going to verify the patch.
Comment 3 Alex Christensen 2016-06-18 18:56:46 PDT 
Comment on attachment 281608 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281608&action=review

So Sierra becomes the default Mac port and elcap results are moved to mac-elcapitan directory.  Seems good.

> LayoutTests/ChangeLog:61
> +        * platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.

This file probably differs on sierra, but you didn't add a new one or modify the existing one.  There are probably several errors we'll find with this patch, but this is a good start.

> LayoutTests/platform/mac/TestExpectations:1411
> +# <rdar://problem/25536266> [Mac][iOS][NETWORK_SESSION] Unable to download BLOB URLs (156180)

This should probably be mine.
Comment 4 Alexey Proskuryakov 2016-06-18 23:22:07 PDT 
> This file probably differs on sierra, but you didn't add a new one or modify the existing one.  There are probably several errors we'll find with this patch, but this is a good start.

Great catch! The expectation actually doesn't differ, but we did have a separate identical copy for some reason. I'll undo this part of the patch.
Comment 5 Alexey Proskuryakov 2016-06-19 17:17:46 PDT 
Committed http://trac.webkit.org/r202219