Bug 158903 – Add test expectations for macOS Sierra

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

Add test expectations for macOS Sierra.

[Alexey Proskuryakov]

Created attachment 281608 [details]
Proposed patch

[Alexey Proskuryakov]

Sadly, looks like EWS is not going to verify the patch.

[Alex Christensen]

Comment on attachment 281608 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281608&action=review

So Sierra becomes the default Mac port and elcap results are moved to mac-elcapitan directory.  Seems good.

> LayoutTests/ChangeLog:61
> +        * platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.

This file probably differs on sierra, but you didn't add a new one or modify the existing one.  There are probably several errors we'll find with this patch, but this is a good start.

> LayoutTests/platform/mac/TestExpectations:1411
> +# <rdar://problem/25536266> [Mac][iOS][NETWORK_SESSION] Unable to download BLOB URLs (156180)

This should probably be mine.

[Alexey Proskuryakov]

> This file probably differs on sierra, but you didn't add a new one or modify the existing one.  There are probably several errors we'll find with this patch, but this is a good start.

Great catch! The expectation actually doesn't differ, but we did have a separate identical copy for some reason. I'll undo this part of the patch.

[Alexey Proskuryakov]

Committed http://trac.webkit.org/r202219