158864 – Drop some unnecessary header includes

RESOLVED FIXED 158864

Drop some unnecessary header includes

https://bugs.webkit.org/show_bug.cgi?id=158864

Summary Drop some unnecessary header includes

Chris Dumez

Reported 2016-06-16 21:40:56 PDT

Drop some unnecessary header includes to try and reduce build times.

Attachments
Patch (27.44 KB, patch) 2016-06-16 22:06 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (27.51 KB, patch) 2016-06-16 22:12 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch for landing (27.93 KB, patch) 2016-06-17 00:40 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (14.64 KB, patch) 2017-07-14 09:13 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (15.15 KB, patch) 2017-07-14 09:19 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-06-16 22:06:26 PDT

Created attachment 281531 [details] Patch

Chris Dumez

Comment 2 2016-06-16 22:12:24 PDT

Created attachment 281534 [details] Patch

Alexey Proskuryakov

Comment 3 2016-06-16 23:22:33 PDT

Comment on attachment 281534 [details] Patch rs=me, but this breaks Efl. ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp: In member function 'void WebCore::ScrollbarThemeEfl::loadThemeIfNeeded(WebCore::Scrollbar&)': ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:134:52: error: invalid use of incomplete type 'class WebCore::Frame' Page* page = downcast<FrameView>(view)->frame().page(); ^ In file included from ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:32:0: ../../Source/WebCore/page/FrameView.h:48:7: note: forward declaration of 'class WebCore::Frame' class Frame; ^ ninja: build stopped: subcommand failed.

Gyuyoung Kim

Comment 4 2016-06-17 00:11:58 PDT

(In reply to comment #3) > Comment on attachment 281534 [details] > Patch > > rs=me, but this breaks Efl. > > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp: In member function > 'void WebCore::ScrollbarThemeEfl::loadThemeIfNeeded(WebCore::Scrollbar&)': > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:134:52: error: > invalid use of incomplete type 'class WebCore::Frame' > Page* page = downcast<FrameView>(view)->frame().page(); > ^ > In file included from > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:32:0: > ../../Source/WebCore/page/FrameView.h:48:7: note: forward declaration of > 'class WebCore::Frame' > class Frame; > ^ > ninja: build stopped: subcommand failed. Please add #include "Frame.h" in ScrollbarthemeEfl.cpp :)

Gyuyoung Kim

Comment 5 2016-06-17 00:40:37 PDT

Created attachment 281546 [details] Patch for landing

Gyuyoung Kim

Comment 6 2016-06-17 00:41:36 PDT

(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 281534 [details] > > Patch > > > > rs=me, but this breaks Efl. > > > > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp: In member function > > 'void WebCore::ScrollbarThemeEfl::loadThemeIfNeeded(WebCore::Scrollbar&)': > > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:134:52: error: > > invalid use of incomplete type 'class WebCore::Frame' > > Page* page = downcast<FrameView>(view)->frame().page(); > > ^ > > In file included from > > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:32:0: > > ../../Source/WebCore/page/FrameView.h:48:7: note: forward declaration of > > 'class WebCore::Frame' > > class Frame; > > ^ > > ninja: build stopped: subcommand failed. > > Please add #include "Frame.h" in ScrollbarthemeEfl.cpp :) Fix it instead of Chris.

Chris Dumez

Comment 7 2016-06-17 08:43:17 PDT

Comment on attachment 281546 [details] Patch for landing Clearing flags on attachment: 281546 Committed r202167: <http://trac.webkit.org/changeset/202167>

Chris Dumez

Comment 8 2016-06-17 08:43:21 PDT

All reviewed patches have been landed. Closing bug.

Chris Dumez

Comment 9 2016-06-17 08:43:40 PDT

(In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #3) > > > Comment on attachment 281534 [details] > > > Patch > > > > > > rs=me, but this breaks Efl. > > > > > > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp: In member function > > > 'void WebCore::ScrollbarThemeEfl::loadThemeIfNeeded(WebCore::Scrollbar&)': > > > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:134:52: error: > > > invalid use of incomplete type 'class WebCore::Frame' > > > Page* page = downcast<FrameView>(view)->frame().page(); > > > ^ > > > In file included from > > > ../../Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:32:0: > > > ../../Source/WebCore/page/FrameView.h:48:7: note: forward declaration of > > > 'class WebCore::Frame' > > > class Frame; > > > ^ > > > ninja: build stopped: subcommand failed. > > > > Please add #include "Frame.h" in ScrollbarthemeEfl.cpp :) > > Fix it instead of Chris. Thank you Gyuyoung!

Yusuke Suzuki

Comment 10 2017-07-14 09:13:22 PDT

Reopening to attach new patch.

Yusuke Suzuki

Comment 11 2017-07-14 09:13:24 PDT

Created attachment 315428 [details] Patch

Yusuke Suzuki

Comment 12 2017-07-14 09:19:55 PDT

Created attachment 315430 [details] Patch

Yusuke Suzuki

Comment 13 2017-07-14 09:20:39 PDT

Oops, I mis-specified bug number, sorry.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebCore Misc.

Assignee

Chris Dumez

Reported

2016-06-16 21:40 PDT

Modified

2017-07-22 00:45 PDT History

CC List

4 users Show

URL

Keywords

Depends on

Blocks