Bug 158863 - [JSC] Introduce static symbols
Summary: [JSC] Introduce static symbols
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on: 165093
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-16 19:58 PDT by Yusuke Suzuki
Modified: 2017-07-21 09:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.28 KB, patch)
2017-07-14 09:23 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (16.23 KB, patch)
2017-07-14 10:42 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (15.75 KB, patch)
2017-07-14 11:09 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (15.58 KB, patch)
2017-07-14 11:09 PDT, Yusuke Suzuki
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-06-16 19:58:27 PDT
Considering about static symbols like StaticASCIILiteral.
It allow static hash table to use symbols, since symbols are not included in atomic string tables.
Moreover, it allows us to include private symbol properties in the static hash table.
It can make JSGlobalObject's private symbol's properties lazy.
Comment 1 Yusuke Suzuki 2017-07-14 09:23:52 PDT
Created attachment 315431 [details]
Patch
Comment 2 Yusuke Suzuki 2017-07-14 10:42:22 PDT
Created attachment 315443 [details]
Patch
Comment 3 Yusuke Suzuki 2017-07-14 11:09:04 PDT
Created attachment 315455 [details]
Patch
Comment 4 Yusuke Suzuki 2017-07-14 11:09:44 PDT
Created attachment 315456 [details]
Patch
Comment 5 Darin Adler 2017-07-21 09:30:52 PDT
Comment on attachment 315456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315456&action=review

> Source/WTF/wtf/text/SymbolImpl.h:57
> +        template<unsigned charactersCount>

I would be better grammar to say "character count" rather than "characters count".
Comment 6 Yusuke Suzuki 2017-07-21 09:32:21 PDT
Comment on attachment 315456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315456&action=review

>> Source/WTF/wtf/text/SymbolImpl.h:57
>> +        template<unsigned charactersCount>
> 
> I would be better grammar to say "character count" rather than "characters count".

OK, fixed. I also fixed StringImpl's same name.
Comment 7 Yusuke Suzuki 2017-07-21 09:41:45 PDT
Committed r219731: <http://trac.webkit.org/changeset/219731>