Bug 158857 - Add HTTPHeaderMap::set() overload taking a NSString*
Summary: Add HTTPHeaderMap::set() overload taking a NSString*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 158827
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-16 16:34 PDT by Chris Dumez
Modified: 2016-06-16 19:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2016-06-16 16:35 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2016-06-16 16:36 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-06-16 16:34:44 PDT
Add HTTPHeaderMap::set() overloading taking a NSString* in addition to the one taking a CFStringRef. It is useful for the Cocoa implementation of ResourceRequest::doUpdateResourceRequest() which does:
[[m_nsRequest allHTTPHeaderFields] enumerateKeysAndObjectsUsingBlock: ^(NSString *name, NSString *value, BOOL *) {
        m_httpHeaderFields.set(name, value);
    }];
Comment 1 Chris Dumez 2016-06-16 16:35:59 PDT
Created attachment 281501 [details]
Patch
Comment 2 Chris Dumez 2016-06-16 16:36:29 PDT
Created attachment 281502 [details]
Patch
Comment 3 WebKit Commit Bot 2016-06-16 19:30:43 PDT
Comment on attachment 281502 [details]
Patch

Clearing flags on attachment: 281502

Committed r202153: <http://trac.webkit.org/changeset/202153>
Comment 4 WebKit Commit Bot 2016-06-16 19:30:48 PDT
All reviewed patches have been landed.  Closing bug.