Bug 158852 - Opcode.h requires Bytecodes.h, but it is not found
Summary: Opcode.h requires Bytecodes.h, but it is not found
Status: RESOLVED DUPLICATE of bug 157261
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-16 15:17 PDT by Rafael Fontenelle
Modified: 2016-09-01 09:24 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Fontenelle 2016-06-16 15:17:25 PDT 
Compilation fails when Opcode.h tries to include the header file 'Bytecodes.h', but there is no such file

See build and configure log: https://gist.github.com/josephgbr/b62ff3b2ba70d1ce523593a2d0335924
Comment 1 Yusuke Suzuki 2016-06-23 00:35:46 PDT 
Reproduced on GTK port.
I think this is CMake build dependency issue. Bytecodes.h generation should be done before building any other cpps out of JSC.
Currently, it seems that WebCore binding code build starts before generating Bytecodes.h.

I think I saw such a problem in GYP in chromium...
Building the object files itself can be done without the shared library (libjavascriptcoregtk.so). Building WebCore and JavaScriptCore in parallel can be done if there are no such generated header dependencies.

So I guess that we need to explicitly say that these building depends on the Bytecodes.h header generation.
Comment 2 Yusuke Suzuki 2016-08-25 20:58:00 PDT 
In https://trac.webkit.org/changeset/204994, I appended Bytecodes.h to JavaScriptCore_HEADERS in CMakeLists.txt.
Does this issue still remain?
Comment 3 Yusuke Suzuki 2016-08-31 21:03:50 PDT 
Hm, the issue still remains.
Comment 4 Fujii Hironori 2016-09-01 07:01:40 PDT 
Same?
  Bug 161477 – webkit-gtk 2.13.90 fails to build due to missing Bytecodes.h
Comment 5 Yusuke Suzuki 2016-09-01 09:24:36 PDT 
(In reply to comment #4)
> Same?
>   Bug 161477 – webkit-gtk 2.13.90 fails to build due to missing Bytecodes.h

Nice!

*** This bug has been marked as a duplicate of bug 157261 ***