Bug 158851 – [WK2] Improve serialization of SubresourcesEntry to network disk cache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Improve serialization of SubresourcesEntry to network disk cache.

[Chris Dumez]

Created attachment 281479 [details]
Patch

[Antti Koivisto]

Comment on attachment 281479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281479&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:90
> -    static const unsigned version = 7;
> +    static const unsigned version = 8;

Since you are increasing the version can you also make the directory names more consistent/informative? Currently we have foo.bar/resource/ and foo.bar/subresources/ which sound confusingly similar. Also they could be capitalized like Blobs/Records. Resources/SpeculativeDependencies or something.

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 281479 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281479&action=review
> 
> > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:90
> > -    static const unsigned version = 7;
> > +    static const unsigned version = 8;
> 
> Since you are increasing the version can you also make the directory names
> more consistent/informative? Currently we have foo.bar/resource/ and
> foo.bar/subresources/ which sound confusingly similar. Also they could be
> capitalized like Blobs/Records. Resources/SpeculativeDependencies or
> something.

Hmm. Right now I build the path using key.type() and the type is either "resource" / "subresources". We could easily capitalize the type when using it as folder name. However, if I rename "subresources" to something else, I would have to rename my SubresourcesEntry class as well (which I don't really want to do right now).

How about we just capitalize the type when using it as folder name in this patch?

[Chris Dumez]

Created attachment 281499 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 281499 [details]
Patch

Clearing flags on attachment: 281499

Committed r202148: <http://trac.webkit.org/changeset/202148>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Since subresource is one (non-English, jargon) word, not two word ("sub resources"), it should be spelled Subresources, not SubResources.

[Chris Dumez]

(In reply to comment #7)
> Since subresource is one (non-English, jargon) word, not two word ("sub
> resources"), it should be spelled Subresources, not SubResources.

Darn, I thought about this. Since it is sub-resource and not subresource, I thought it made sense to capitalize as SubResource. Apparently I was wrong.