Bug 15885 - Add move virtual void evaluate() =0 from Node into new ExpressionNode subclass
Summary: Add move virtual void evaluate() =0 from Node into new ExpressionNode subclass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 15910
  Show dependency tree / graph
 
Reported: 2007-11-07 10:07 PST by Eric Seidel (no email)
Modified: 2007-11-08 17:54 PST (History)
1 user (show)

See Also:

Attachments
the patch (81.53 KB, patch)
2007-11-08 15:51 PST, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-11-07 10:07:35 PST 
Add move virtual void evaluate() =0 from Node into new StatementNode subclass

Darin suggested this as part of comments on bug 15879.  I agree, I think it would make the node tree cleaner.
Comment 1 Eric Seidel (no email) 2007-11-08 15:51:00 PST 
Created attachment 17131 [details]
the patch

Well, this does as requested... adds an ExpressionNode and makes all expressions use it/subclass from it instead of Node.
Comment 2 Darin Adler 2007-11-08 16:23:11 PST 
Comment on attachment 17131 [details]
the patch

Good first step. Now some of the nodes should probably not be a subclass of ExpressionNode, since they're not used in a polymorphic way.
Comment 3 Eric Seidel (no email) 2007-11-08 16:49:45 PST 
Committed as r27622.