Bug 158849 - Fix macOS Sierra build
Summary: Fix macOS Sierra build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-16 14:36 PDT by Anders Carlsson
Modified: 2016-06-20 10:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (18.42 KB, patch)
2016-06-16 14:38 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-06-16 14:36:51 PDT 
Fix macOS Sierra build
Comment 1 Anders Carlsson 2016-06-16 14:38:50 PDT 
Created attachment 281474 [details]
Patch
Comment 2 Anders Carlsson 2016-06-16 15:44:33 PDT 
Committed r202142: <http://trac.webkit.org/changeset/202142>
Comment 3 Jon Lee 2016-06-18 12:03:00 PDT 
Comment on attachment 281474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281474&action=review

> Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm:403
> +//        layer.contents = (id)m_frontBuffer.surface->surface();

Is this correct?
Comment 4 Chris Dumez 2016-06-20 09:48:14 PDT 
(In reply to comment #3)
> Comment on attachment 281474 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281474&action=review
> 
> > Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm:403
> > +//        layer.contents = (id)m_frontBuffer.surface->surface();
> 
> Is this correct?

This commented line caused a 11% progression on JSBench / iOS. JSBench regressed by ~11% when Simon uncommented this line in r202224.

No action is necessary, I just want to document this here.
Comment 5 Simon Fraser (smfr) 2016-06-20 10:20:34 PDT 
That is interesting data!