fullscreen/video-controls-override.html fails with GTK because the GTK test-expected file was not updated after an update of the test. MAC was version was updated, but not the default test-expected, nor EFL. GTK produces the same result as MAC, and other ports skip the test. Therefore, it seems that the MAC version could be used as the default version and dedicated versions could be removed.
Created attachment 281460 [details] Patch
Comment on attachment 281460 [details] Patch Clearing flags on attachment: 281460 Committed r202164: <http://trac.webkit.org/changeset/202164>
All reviewed patches have been landed. Closing bug.
Comment on attachment 281460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281460&action=review > LayoutTests/fullscreen/video-controls-override-expected.txt:11 > -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK > +EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL This isn't right, the test results shouldn't have a failure. If the test is incorrect the test should be fixed. If the observed behavior is incorrect, that should be fixed.
(In reply to comment #4) > Comment on attachment 281460 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281460&action=review > > > LayoutTests/fullscreen/video-controls-override-expected.txt:11 > > -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK > > +EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL > > This isn't right, the test results shouldn't have a failure. > > If the test is incorrect the test should be fixed. If the observed behavior > is incorrect, that should be fixed. oops, sorry, I missed that, I assumed that the current result was ok and just copied