RESOLVED FIXED Bug 158838
Update test-expected file for failing fullscreen test 
https://bugs.webkit.org/show_bug.cgi?id=158838
Summary Update test-expected file for failing fullscreen test
Romain Bellessort
Reported 2016-06-16 08:46:22 PDT
fullscreen/video-controls-override.html fails with GTK because the GTK test-expected file was not updated after an update of the test. MAC was version was updated, but not the default test-expected, nor EFL. GTK produces the same result as MAC, and other ports skip the test. Therefore, it seems that the MAC version could be used as the default version and dedicated versions could be removed.
Attachments
Patch (5.68 KB, patch)
2016-06-16 08:54 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2016-06-16 08:54:34 PDT
Created attachment 281460 [details] Patch
WebKit Commit Bot
Comment 2 2016-06-17 04:46:14 PDT
Comment on attachment 281460 [details] Patch Clearing flags on attachment: 281460 Committed r202164: <http://trac.webkit.org/changeset/202164>
WebKit Commit Bot
Comment 3 2016-06-17 04:46:18 PDT
All reviewed patches have been landed. Closing bug.
Eric Carlson
Comment 4 2016-06-17 07:20:11 PDT
Comment on attachment 281460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281460&action=review > LayoutTests/fullscreen/video-controls-override-expected.txt:11 > -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK > +EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL This isn't right, the test results shouldn't have a failure. If the test is incorrect the test should be fixed. If the observed behavior is incorrect, that should be fixed.
Carlos Garcia Campos
Comment 5 2016-06-17 08:22:04 PDT
(In reply to comment #4) > Comment on attachment 281460 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281460&action=review > > > LayoutTests/fullscreen/video-controls-override-expected.txt:11 > > -EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK > > +EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL > > This isn't right, the test results shouldn't have a failure. > > If the test is incorrect the test should be fixed. If the observed behavior > is incorrect, that should be fixed. oops, sorry, I missed that, I assumed that the current result was ok and just copied
Note You need to log in before you can comment on or make changes to this bug.