Bug 158828 – [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

[iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location

[Simon Fraser (smfr)]

Created attachment 281439 [details]
Patch

[WebKit Commit Bot]

Attachment 281439 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1070:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1071:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

Comment on attachment 281439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281439&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:255
> +- (void)keyboardAccessoryBarPrevious WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);

Why for macOS as well?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:257
> +@property (nonatomic) BOOL forceIPadStyleZoomOnInputFocus WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);

Ditto

> LayoutTests/fast/forms/ios/resources/zooming-test-utils.js:2
> +function testZoomAfterTap(targetElement, xOffset, yOffset, useIPadBehavior)

Do you also need to update the tests you added yesterday, now that this function takes one extra parameter?

[Simon Fraser (smfr)]

https://trac.webkit.org/r202132