Bug 158824 - Expose _shouldExpandToViewHeightForAutoLayout SPI on WKWebView
Summary: Expose _shouldExpandToViewHeightForAutoLayout SPI on WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-15 19:07 PDT by Tim Horton
Modified: 2016-06-15 19:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.91 KB, patch)
2016-06-15 19:07 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-06-15 19:07:03 PDT 
Expose _shouldExpandToViewHeightForAutoLayout SPI on WKWebView
Comment 1 Tim Horton 2016-06-15 19:07:27 PDT 
Created attachment 281425 [details]
Patch
Comment 2 Tim Horton 2016-06-15 19:07:49 PDT 
rdar://problem/23713857
Comment 3 WebKit Commit Bot 2016-06-15 19:09:13 PDT 
Attachment 281425 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:146:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:159:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Simon Fraser (smfr) 2016-06-15 19:15:47 PDT 
Comment on attachment 281425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281425&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:195
> +@property (nonatomic, setter=_setShouldExpandToViewHeightForAutoLayout:) BOOL _shouldExpandToViewHeightForAutoLayout WK_AVAILABLE(WK_MAC_TBA, NA);

Should this say _setShouldExpand*Content*ToViewHeightForAutoLayout ?
Otherwise it seems to be saying that the WKWebView should expand to something.
Comment 5 Tim Horton 2016-06-15 19:20:28 PDT 
http://trac.webkit.org/changeset/202120