Remove unused didCancelAuthenticationChallenge
Created attachment 281411 [details] Patch
Attachment 281411 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 281464 [details] Patch
Comment on attachment 281464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281464&action=review > Source/WebCore/ChangeLog:12 > + (WebCore::ResourceLoadNotifier::willSendRequest): The above two methods didn't change. They shouldn't appear in the ChangeLog! > Source/WebCore/ChangeLog:17 > + (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto. > Source/WebCore/ChangeLog:24 > + (WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Ditto. > Source/WebCore/ChangeLog:28 > + (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Ditto. > Source/WebCore/ChangeLog:32 > + (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Ditto. > Source/WebCore/ChangeLog:36 > + (-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]): Ditto. > Source/WebKit2/ChangeLog:10 > + (-[WKDownloadAsDelegate downloadShouldUseCredentialStorage:]): Ditto. > Source/WebKit2/ChangeLog:14 > + (WebKit::NetworkLoad::receivedCancellation): Ditto. > Source/WebKit2/ChangeLog:19 > + (WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Ditto. > Source/WebKit/ios/ChangeLog:10 > + (-[WebDefaultResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]): Ditto. > Source/WebKit/mac/ChangeLog:10 > + (-[WebDownloadInternal download:didReceiveResponse:]): Ditto. > Source/WebKit/mac/ChangeLog:15 > + (WebFrameLoaderClient::dispatchDidReceiveResponse): Ditto. > Source/WebKit/win/ChangeLog:10 > + (WebFrameLoaderClient::dispatchWillSendRequest): Ditto.
Comment on attachment 281464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281464&action=review r=me if you fix up the ChangeLog to remove methods that were not changed. > Source/WebCore/ChangeLog:4 > + Remove unused didCancelAuthenticationChallenge > + https://bugs.webkit.org/show_bug.cgi?id=158819 Would be good to explain why it was removed, at least in the bug. I believe this callback was deprecated by CFNetwork, so we switched to use something else instead (although I don't know what).
(In reply to comment #5) > Comment on attachment 281464 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281464&action=review > > r=me if you fix up the ChangeLog to remove methods that were not changed. Filed this bug to track that issue: Bug 159067: prepare-ChangeLog lists methods that were not modified when deleting other methods
http://trac.webkit.org/changeset/202410