WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
158819
Remove unused didCancelAuthenticationChallenge
https://bugs.webkit.org/show_bug.cgi?id=158819
Summary
Remove unused didCancelAuthenticationChallenge
Alex Christensen
Reported
2016-06-15 16:29:27 PDT
Remove unused didCancelAuthenticationChallenge
Attachments
Patch
(27.74 KB, patch)
2016-06-15 17:25 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(31.32 KB, patch)
2016-06-16 11:47 PDT
,
Alex Christensen
ddkilzer
: review+
ddkilzer
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2016-06-15 17:25:11 PDT
Created
attachment 281411
[details]
Patch
WebKit Commit Bot
Comment 2
2016-06-15 17:27:31 PDT
Attachment 281411
[details]
did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3
2016-06-16 11:47:22 PDT
Created
attachment 281464
[details]
Patch
Brent Fulgham
Comment 4
2016-06-16 15:39:12 PDT
Comment on
attachment 281464
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=281464&action=review
> Source/WebCore/ChangeLog:12 > + (WebCore::ResourceLoadNotifier::willSendRequest):
The above two methods didn't change. They shouldn't appear in the ChangeLog!
> Source/WebCore/ChangeLog:17 > + (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
Ditto.
> Source/WebCore/ChangeLog:24 > + (WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace):
Ditto.
> Source/WebCore/ChangeLog:28 > + (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
Ditto.
> Source/WebCore/ChangeLog:32 > + (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):
Ditto.
> Source/WebCore/ChangeLog:36 > + (-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
Ditto.
> Source/WebKit2/ChangeLog:10 > + (-[WKDownloadAsDelegate downloadShouldUseCredentialStorage:]):
Ditto.
> Source/WebKit2/ChangeLog:14 > + (WebKit::NetworkLoad::receivedCancellation):
Ditto.
> Source/WebKit2/ChangeLog:19 > + (WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
Ditto.
> Source/WebKit/ios/ChangeLog:10 > + (-[WebDefaultResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]):
Ditto.
> Source/WebKit/mac/ChangeLog:10 > + (-[WebDownloadInternal download:didReceiveResponse:]):
Ditto.
> Source/WebKit/mac/ChangeLog:15 > + (WebFrameLoaderClient::dispatchDidReceiveResponse):
Ditto.
> Source/WebKit/win/ChangeLog:10 > + (WebFrameLoaderClient::dispatchWillSendRequest):
Ditto.
David Kilzer (:ddkilzer)
Comment 5
2016-06-23 12:11:51 PDT
Comment on
attachment 281464
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=281464&action=review
r=me if you fix up the ChangeLog to remove methods that were not changed.
> Source/WebCore/ChangeLog:4 > + Remove unused didCancelAuthenticationChallenge > +
https://bugs.webkit.org/show_bug.cgi?id=158819
Would be good to explain why it was removed, at least in the bug. I believe this callback was deprecated by CFNetwork, so we switched to use something else instead (although I don't know what).
David Kilzer (:ddkilzer)
Comment 6
2016-06-23 12:17:25 PDT
(In reply to
comment #5
)
> Comment on
attachment 281464
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=281464&action=review
> > r=me if you fix up the ChangeLog to remove methods that were not changed.
Filed this bug to track that issue:
Bug 159067
: prepare-ChangeLog lists methods that were not modified when deleting other methods
Alex Christensen
Comment 7
2016-06-23 19:47:47 PDT
http://trac.webkit.org/changeset/202410
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug