WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
158815
[iOS] Media controls are too cramped with small video
https://bugs.webkit.org/show_bug.cgi?id=158815
Summary
[iOS] Media controls are too cramped with small video
Antoine Quint
Reported
2016-06-15 15:30:35 PDT
Created
attachment 281393
[details]
Testcase Opening up the attached test file in landscape on a 4" iPhone shows cramped controls.
Attachments
Testcase
(614 bytes, text/html)
2016-06-15 15:30 PDT
,
Antoine Quint
no flags
Details
Screenshot
(101.17 KB, image/png)
2016-06-15 15:30 PDT
,
Antoine Quint
no flags
Details
Patch
(10.33 KB, patch)
2016-06-21 08:11 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews102 for mac-yosemite
(1.11 MB, application/zip)
2016-06-21 09:00 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2
(1.14 MB, application/zip)
2016-06-21 09:02 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews113 for mac-yosemite
(1.71 MB, application/zip)
2016-06-21 09:14 PDT
,
Build Bot
no flags
Details
Patch
(14.43 KB, patch)
2016-06-24 08:12 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews102 for mac-yosemite
(899.84 KB, application/zip)
2016-06-24 08:57 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2
(902.39 KB, application/zip)
2016-06-24 09:00 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from ews116 for mac-yosemite
(1.53 MB, application/zip)
2016-06-24 09:08 PDT
,
Build Bot
no flags
Details
Patch
(14.45 KB, patch)
2016-06-24 09:22 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(18.34 KB, patch)
2016-06-27 05:40 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch for landing
(18.69 KB, patch)
2016-06-30 03:35 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(18.69 KB, patch)
2016-06-30 03:37 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch for landing
(18.68 KB, patch)
2016-06-30 07:39 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Patch
(20.14 KB, patch)
2016-06-30 09:41 PDT
,
Antoine Quint
no flags
Details
Formatted Diff
Diff
Show Obsolete
(13)
View All
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2016-06-15 15:30:52 PDT
Created
attachment 281394
[details]
Screenshot
Radar WebKit Bug Importer
Comment 2
2016-06-15 15:33:34 PDT
<
rdar://problem/26824238
>
Antoine Quint
Comment 3
2016-06-21 08:11:39 PDT
Created
attachment 281747
[details]
Patch
Antoine Quint
Comment 4
2016-06-21 08:13:12 PDT
No tests yet, I'm having timeouts on all tests with the test runner (see
rdar://problem/26918438
). Feedback welcome on the source changes so far though. I will update the patch with tests when I have a working test runner.
Build Bot
Comment 5
2016-06-21 09:00:03 PDT
Comment on
attachment 281747
[details]
Patch
Attachment 281747
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/1542342
New failing tests: media/media-document-audio-repaint.html media/controls-strict.html media/video-volume-slider.html media/controls-styling.html fast/hidpi/video-controls-in-hidpi.html media/video-display-toggle.html media/media-controls-drag-timeline-set-controls-property.html media/controls-drag-timebar.html media/video-controls-rendering.html accessibility/media-element.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html media/track/track-cue-rendering-horizontal.html http/tests/media/hls/video-controls-live-stream.html media/controls-after-reload.html
Build Bot
Comment 6
2016-06-21 09:00:06 PDT
Created
attachment 281749
[details]
Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 7
2016-06-21 09:02:09 PDT
Comment on
attachment 281747
[details]
Patch
Attachment 281747
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/1542343
New failing tests: media/media-document-audio-repaint.html media/controls-strict.html media/controls-drag-timebar.html media/video-volume-slider.html media/video-display-toggle.html media/media-controls-drag-timeline-set-controls-property.html fast/hidpi/video-controls-in-hidpi.html media/video-controls-rendering.html accessibility/media-element.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html media/track/track-cue-rendering-horizontal.html http/tests/media/hls/video-controls-live-stream.html http/tests/contentextensions/text-track-blocked.html
Build Bot
Comment 8
2016-06-21 09:02:12 PDT
Created
attachment 281750
[details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 9
2016-06-21 09:14:45 PDT
Comment on
attachment 281747
[details]
Patch
Attachment 281747
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/1542345
New failing tests: media/media-document-audio-repaint.html media/controls-strict.html media/video-volume-slider.html media/controls-styling.html fast/hidpi/video-controls-in-hidpi.html media/video-display-toggle.html media/media-controls-drag-timeline-set-controls-property.html media/controls-drag-timebar.html media/video-controls-rendering.html accessibility/media-element.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html media/track/track-cue-rendering-horizontal.html http/tests/media/hls/video-controls-live-stream.html media/controls-after-reload.html
Build Bot
Comment 10
2016-06-21 09:14:48 PDT
Created
attachment 281751
[details]
Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Dean Jackson
Comment 11
2016-06-23 11:18:23 PDT
Comment on
attachment 281747
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=281747&action=review
> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1318 > if (duration >= 60*60*10) { > - this.controls.currentTime.classList.add(this.ClassNames.sixDigitTime); > - this.controls.remainingTime.classList.add(this.ClassNames.sixDigitTime); > + addTimeClass(this.ClassNames.sixDigitTime); > } else if (duration >= 60*60) { > - this.controls.currentTime.classList.add(this.ClassNames.fiveDigitTime); > - this.controls.remainingTime.classList.add(this.ClassNames.fiveDigitTime); > + addTimeClass(this.ClassNames.fiveDigitTime); > } else if (duration >= 60*10) { > - this.controls.currentTime.classList.add(this.ClassNames.fourDigitTime); > - this.controls.remainingTime.classList.add(this.ClassNames.fourDigitTime); > + addTimeClass(this.ClassNames.fourDigitTime); > } else { > - this.controls.currentTime.classList.add(this.ClassNames.threeDigitTime); > - this.controls.remainingTime.classList.add(this.ClassNames.threeDigitTime); > + addTimeClass(this.ClassNames.threeDigitTime); > }
These all become single line conditionals.
Antoine Quint
Comment 12
2016-06-24 07:27:17 PDT
So some of the failures (maybe all) come from the fact that the scrubber won't display now for the default width of an <audio> or <video> element (300 CSS pixels). That is not ideal in terms of user experience!
Antoine Quint
Comment 13
2016-06-24 08:12:15 PDT
Created
attachment 281976
[details]
Patch
Build Bot
Comment 14
2016-06-24 08:56:58 PDT
Comment on
attachment 281976
[details]
Patch
Attachment 281976
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.webkit.org/results/1562017
New failing tests: media/track/track-cue-rendering-horizontal.html
Build Bot
Comment 15
2016-06-24 08:57:00 PDT
Created
attachment 281978
[details]
Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 16
2016-06-24 09:00:04 PDT
Comment on
attachment 281976
[details]
Patch
Attachment 281976
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.webkit.org/results/1562019
New failing tests: media/track/track-cue-rendering-horizontal.html http/tests/contentextensions/text-track-blocked.html
Build Bot
Comment 17
2016-06-24 09:00:06 PDT
Created
attachment 281979
[details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 18
2016-06-24 09:08:42 PDT
Comment on
attachment 281976
[details]
Patch
Attachment 281976
[details]
did not pass mac-debug-ews (mac): Output:
http://webkit-queues.webkit.org/results/1562025
New failing tests: media/track/track-cue-rendering-horizontal.html
Build Bot
Comment 19
2016-06-24 09:08:45 PDT
Created
attachment 281982
[details]
Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Antoine Quint
Comment 20
2016-06-24 09:22:24 PDT
Created
attachment 281984
[details]
Patch
Antoine Quint
Comment 21
2016-06-27 05:40:49 PDT
Created
attachment 282124
[details]
Patch
WebKit Commit Bot
Comment 22
2016-06-27 12:07:04 PDT
Comment on
attachment 282124
[details]
Patch Clearing flags on attachment: 282124 Committed
r202505
: <
http://trac.webkit.org/changeset/202505
>
WebKit Commit Bot
Comment 23
2016-06-27 12:07:09 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 24
2016-06-27 14:32:00 PDT
The test added with change is very flaky: media/video-controls-drop-and-restore-timeline.html <
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-controls-drop-and-restore-timeline.html
> It also appears to have caused media/controls-drag-timebar.html to time out on El Capitan WK2 <
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols-drag-timebar.html
>
WebKit Commit Bot
Comment 25
2016-06-27 14:41:47 PDT
Re-opened since this is blocked by
bug 159169
Antoine Quint
Comment 26
2016-06-30 03:35:59 PDT
Created
attachment 282427
[details]
Patch for landing
Antoine Quint
Comment 27
2016-06-30 03:37:09 PDT
Created
attachment 282428
[details]
Patch
Eric Carlson
Comment 28
2016-06-30 07:18:48 PDT
Comment on
attachment 282428
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=282428&action=review
> LayoutTests/media/video-controls-drop-and-restore-timeline.html:17 > + return child.classList.contains('dropped');
Minor nit: You use double quotes almost everywhere else, you may as well be consistent.
> LayoutTests/media/video-controls-drop-and-restore-timeline.html:27 > + testExpected("video.controls", null, '!=');
Ditto.
> LayoutTests/media/video-controls-drop-and-restore-timeline.html:37 > + testExpected("timelineContainer = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-timeline-container')", null, "!=");
Minor nit: you could make the first string a template literal.
Antoine Quint
Comment 29
2016-06-30 07:37:55 PDT
Thanks Eric, these will be all addressed when landing.
Antoine Quint
Comment 30
2016-06-30 07:39:54 PDT
Created
attachment 282441
[details]
Patch for landing
WebKit Commit Bot
Comment 31
2016-06-30 08:09:59 PDT
Comment on
attachment 282441
[details]
Patch for landing Clearing flags on attachment: 282441 Committed
r202679
: <
http://trac.webkit.org/changeset/202679
>
WebKit Commit Bot
Comment 32
2016-06-30 08:10:05 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 33
2016-06-30 09:18:12 PDT
Re-opened since this is blocked by
bug 159302
Alexey Proskuryakov
Comment 34
2016-06-30 09:18:42 PDT
This is still causing timeouts on media/controls-drag-timebar.html. Antoine could reproduce locally, rolling out.
Antoine Quint
Comment 35
2016-06-30 09:41:48 PDT
Created
attachment 282447
[details]
Patch
WebKit Commit Bot
Comment 36
2016-06-30 12:11:01 PDT
Comment on
attachment 282447
[details]
Patch Clearing flags on attachment: 282447 Committed
r202694
: <
http://trac.webkit.org/changeset/202694
>
WebKit Commit Bot
Comment 37
2016-06-30 12:11:08 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug