Created attachment 281356 [details] Example of broken `color` with `all: unset` When `all: unset` is defined, the color value is set to black and cannot be changed with future CSS color declarations. This works in Chrome.
I just ran into this issue too. Another demo: https://jsbin.com/noselib/edit?css,output
I’m also running into this in an HTML diffing tool I work on — we use some CSS like: ins.our-special-differ, del.our-special-differ { all: unset; } to make sure there are no conflicting styles on <ins>/<del> elements, and then use a script to adjust the text colors in order to make sure they have enough contrast with the green/red backgrounds of the insertions and deletions. We can't adjust the text color on Safari with this bug, though.
This is happening because the "all: unset" is setting -webkit-text-fill-color to black, and that overrides color.
... and our initial value for -webkit-text-fill-color isn't 'current color', as it should be if it followed fill-color.
^ 'currentcolor'
I guess this is really about how 'currentColor' inherits. The initial value of -webkit-text-fill-color on the root element is 'currentColor', and "all:unset" on the body should thefefore set -webkit-text-fill-color to "inherit" which should inherit currentColor as the keyword, rather than the resolved color value (according to the new currentColor inheritance rules in https://drafts.csswg.org/css-color/#resolving-color-values).
Blink had this issue before too, as described in it's bug tacker: https://bugs.chromium.org/p/chromium/issues/detail?id=420781 I don't see any reason why this cannot be patched.
<rdar://problem/50471104>
(In reply to Gustavo Millasaky from comment #7) > Blink had this issue before too, as described in it's bug tacker: > https://bugs.chromium.org/p/chromium/issues/detail?id=420781 > > I don't see any reason why this cannot be patched. https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-text-fill-color says, "The -webkit-text-fill-color CSS property specifies the fill color of characters of text. If this property is not set, the value of the color property is used." In case of Blink, they drop the support for -webkit-text-fill-color. But WebKit still maintain the support for the css property, so as long as WebKit keep the support this behavior will be maintained as it is currently. The decision whether to keep this property or not should be discussed in WebKit community through this jira comments or via webkit-dev mailing list I think. If community want to keep this property in WebKit then we could resolve this issue as wontfix, otherwise we could drop the support for -webkit-text-fill-color for interoperability I guess.
I saw the blocking issue for this one, and as Simon commented, if currentcolor works as keyword then this issue can be resolved. So it seems that dropping -webkit-text-fill-color is nothing to do with this issue. I will take the blocking issue to solve this one.
To be clear, Blink still support -webkit-text-fill-color.
Created attachment 394006 [details] Patch
Comment on attachment 394006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=394006&action=review > Source/WebCore/css/CSSProperties.json:6315 > + "no-default-color": true What's the justification for using this for -webkit-text-fill-color, but not, say, -webkit-text-stroke-color, -webkit-text-emphasis-color, text-decoration-color etc?
(In reply to Alexey Shvayka from comment #12) > Created attachment 394006 [details] > Patch Hi, Alexey, I think the root cause is 'currentcolor', as Simon said in comment #6. I'm currently working on https://bugs.webkit.org/show_bug.cgi?id=107380, and as soon as it is done I will work on https://bugs.webkit.org/show_bug.cgi?id=193171, which is the bug for 'currentcolor'. So I think it could be good to see this issue's state after having the 'currentcolor' behavior follow the spec in comment #6.
*** Bug 209854 has been marked as a duplicate of this bug. ***
Comment on attachment 394006 [details] Patch The right fix here is make 'currentcolor' work correctly.
*** This bug has been marked as a duplicate of bug 193171 ***