Bug 158770 - [iOS] Play glyph is pixelated when the page zoom is large
Summary: [iOS] Play glyph is pixelated when the page zoom is large
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: iPhone / iPad iOS 9.3
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-14 18:23 PDT by Antoine Quint
Modified: 2016-06-14 19:06 PDT (History)
3 users (show)

See Also:


Attachments
Testcase (521 bytes, text/html)
2016-06-14 18:23 PDT, Antoine Quint
no flags Details
Patch (2.14 KB, patch)
2016-06-14 18:25 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (3.04 KB, patch)
2016-06-14 18:37 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-06-14 18:23:07 PDT
Created attachment 281307 [details]
Testcase

See the attached test case which has a <video> element with a rather large viewport width forcing a lot of page zoom. In that situation, the play glyph over the video is very pixelated.
Comment 1 Antoine Quint 2016-06-14 18:23:23 PDT
<rdar://problem/26092124>
Comment 2 Antoine Quint 2016-06-14 18:25:18 PDT
Created attachment 281308 [details]
Patch
Comment 3 Darin Adler 2016-06-14 18:27:06 PDT
Comment on attachment 281308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281308&action=review

> Source/WebCore/ChangeLog:11
> +        Use the same technique that we use to scale the video controls by using a combination
> +        of CSS "zoom" and "transform" properties to have the video play glyph scaled at its
> +        native size regardless of page zoom.

Should we make a helper function for this to avoid repeating the code?
Comment 4 Antoine Quint 2016-06-14 18:32:27 PDT
(In reply to comment #3)
> Comment on attachment 281308 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281308&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Use the same technique that we use to scale the video controls by using a combination
> > +        of CSS "zoom" and "transform" properties to have the video play glyph scaled at its
> > +        native size regardless of page zoom.
> 
> Should we make a helper function for this to avoid repeating the code?

Sure thing. I'll add an inline function to the `scaleFactor` setter.
Comment 5 Antoine Quint 2016-06-14 18:37:06 PDT
Created attachment 281310 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2016-06-14 19:06:01 PDT
Comment on attachment 281310 [details]
Patch for landing

Clearing flags on attachment: 281310

Committed r202079: <http://trac.webkit.org/changeset/202079>
Comment 7 WebKit Commit Bot 2016-06-14 19:06:04 PDT
All reviewed patches have been landed.  Closing bug.