While simulators are booting up, if someone manually kills a simulator (or simulator gets killed for some reason), we notice following continuos error messages in logs: 14:36:13.791 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:14.875 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:15.961 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:17.050 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:18.137 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided 14:36:19.224 12047 Error in checking Simulator boot status. Could not print domain: 141: Reentrancy avoided
This happens because the command use to check the Simulator boot status fails, and we keep retrying every second until timeout is hit (default timeout is 5 mins).
Created attachment 281288 [details] Proposed patch
Comment on attachment 281288 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=281288&action=review > Tools/Scripts/webkitpy/xcode/simulator.py:288 > + _log.warn("Error in checking Simulator boot status. Will retry in 1 second.") > + if Simulator.device_state(udid) != Simulator.DeviceState.BOOTED: > + raise RuntimeError('Simuator device quit unexpectedly.') Can't the "will retry" message be untrue now?
It is still true. Even if the simulator device is booted, sometimes "xcrun simctl spawan uddid launchctl" command fails for unknown reasons, in that case we do retry after 1 seconds.
What if we raise the exception instead of waiting?
Created attachment 281293 [details] Updated patch
Comment on attachment 281293 [details] Updated patch Clearing flags on attachment: 281293 Committed r202070: <http://trac.webkit.org/changeset/202070>
All reviewed patches have been landed. Closing bug.