Bug 158754 - The Array species constructor watchpoints should be created the first time they are needed rather than on creation
Summary: The Array species constructor watchpoints should be created the first time th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-14 14:25 PDT by Keith Miller
Modified: 2016-06-14 15:32 PDT (History)
5 users (show)

See Also:

Attachments
Patch (18.71 KB, patch)
2016-06-14 14:41 PDT, Keith Miller 		benjamin: review+
Details | Formatted Diff | Diff
Micro-benchmark results (885 bytes, text/plain)
2016-06-14 14:42 PDT, Keith Miller 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-06-14 14:25:25 PDT 
The Array species constructor watchpoints should be created the first time they are needed rather than on creation
Comment 1 Keith Miller 2016-06-14 14:41:32 PDT 
Created attachment 281281 [details]
Patch
Comment 2 Keith Miller 2016-06-14 14:42:28 PDT 
Created attachment 281282 [details]
Micro-benchmark results
Comment 3 Benjamin Poulain 2016-06-14 14:59:08 PDT 
Comment on attachment 281281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281281&action=review

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1110
> +    // And that Array[Symbol.species] is the primordial GetterSetter.

And -> and
Comment 4 Benjamin Poulain 2016-06-14 15:00:19 PDT 
Maybe add 2 tests where you warm up with-the-original-constructor/without-species, then modify, and run a loop again verifying the changes.
Comment 5 Keith Miller 2016-06-14 15:32:33 PDT 
Committed r202067: <http://trac.webkit.org/changeset/202067>