Bug 158743 – REGRESSION (r202020): El Capitan CMake Debug build broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

This change caused the El Capitan CMake Debug build to break:

Bug 158716: False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
<https://webkit.org/b/158716>
<https://trac.webkit.org/r202020>

[David Kilzer (:ddkilzer)]

Created attachment 281266 [details]
Patch v1

[WebKit Commit Bot]

Comment on attachment 281266 [details]
Patch v1

Clearing flags on attachment: 281266

Committed r202056: <http://trac.webkit.org/changeset/202056>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

This is fixed (no longer hitting the error):

<https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/5881>

Here's the last build with the error for this bug:

<https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/5880>

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:2:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTree.h:38:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h:55:44: error: expected function body after function declarator
WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED;
                                           ^
1 error generated.
make[2]: *** [Tools/DumpRenderTree/CMakeFiles/DumpRenderTree.dir/DumpRenderTreeCommon.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/PixelDumpSupport.cpp:33:
In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/DumpRenderTree.h:38:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/DumpRenderTree/mac/DumpRenderTreeMac.h:55:44: error: expected function body after function declarator
WebView *createWebViewAndOffscreenWindow() NS_RETURNS_RETAINED;
                                           ^
1 error generated.

[David Kilzer (:ddkilzer)]

Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from Tools/DumpRenderTree/CMakeLists.txt.

Going to attempt a build fix.

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from
> Tools/DumpRenderTree/CMakeLists.txt.
> 
> Going to attempt a build fix.

And TestNetscapePlugin had the same issue.

Attempt a build fix:

Committed r202060: <http://trac.webkit.org/changeset/202060>

[David Kilzer (:ddkilzer)]

(In reply to comment #6)
> (In reply to comment #5)
> > Oops, DumpRenderTree is now missing the common DumpRenderTree_SOURCES from
> > Tools/DumpRenderTree/CMakeLists.txt.
> > 
> > Going to attempt a build fix.
> 
> And TestNetscapePlugin had the same issue.
> 
> Attempt a build fix:
> 
> Committed r202060: <http://trac.webkit.org/changeset/202060>

The build fix would have worked if not for a silly typo, fixed here:

Committed r202065: <http://trac.webkit.org/changeset/202065>

[David Kilzer (:ddkilzer)]

Finally!

<https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/5889>