Bug 158726 - Tests don't work in iOS Simulator when ASan is enabled
Summary: Tests don't work in iOS Simulator when ASan is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-13 23:15 PDT by Alexey Proskuryakov
Modified: 2016-06-14 16:36 PDT (History)
5 users (show)

See Also:

Attachments
proposed fix (2.41 KB, patch)
2016-06-13 23:19 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2016-06-13 23:15:24 PDT 
LayoutTestRelay terminates right away.
Comment 1 Alexey Proskuryakov 2016-06-13 23:19:24 PDT 
Created attachment 281236 [details]
proposed fix
Comment 2 David Kilzer (:ddkilzer) 2016-06-14 16:03:42 PDT 
<rdar://problem/20696702>
Comment 3 David Kilzer (:ddkilzer) 2016-06-14 16:07:23 PDT 
Comment on attachment 281236 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281236&action=review

r=me

> Tools/Scripts/webkitpy/port/driver.py:325
> +        # FIXME: DYLD_* variables should be Mac-only. Even iOS Simulator doesn't need them, as LayoutTestRelay is a host binary.

Please file a bug and add it to the comment to track the issue.
Comment 4 Alexey Proskuryakov 2016-06-14 16:13:57 PDT 
Comment on attachment 281236 [details]
proposed fix

Discussed it with David in person - I don't want to file a bug about this code reorganization idea, as I don't see how such a bug can be useful.
Comment 5 WebKit Commit Bot 2016-06-14 16:36:54 PDT 
Comment on attachment 281236 [details]
proposed fix

Clearing flags on attachment: 281236

Committed r202071: <http://trac.webkit.org/changeset/202071>
Comment 6 WebKit Commit Bot 2016-06-14 16:36:58 PDT 
All reviewed patches have been landed.  Closing bug.