Bug 158722 - Make RenderBlock::insertInto/RemoveFromTrackedRendererMaps functions static.
Summary: Make RenderBlock::insertInto/RemoveFromTrackedRendererMaps functions static.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-13 19:59 PDT by zalan
Modified: 2016-06-14 09:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.39 KB, patch)
2016-06-13 20:09 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (10.36 KB, patch)
2016-06-14 08:34 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-06-13 19:59:15 PDT
They manipulate the static tracker maps. No need to have them on RenderBlock.
Comment 1 zalan 2016-06-13 20:09:44 PDT
Created attachment 281229 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-06-13 21:07:18 PDT
Comment on attachment 281229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281229&action=review

> Source/WebCore/rendering/RenderBlock.cpp:267
> +            HashSet<const RenderBlock*>* containerSet = it->value.get();

Auto?
Comment 3 zalan 2016-06-14 08:34:09 PDT
Created attachment 281260 [details]
Patch
Comment 4 WebKit Commit Bot 2016-06-14 09:05:40 PDT
Comment on attachment 281260 [details]
Patch

Clearing flags on attachment: 281260

Committed r202044: <http://trac.webkit.org/changeset/202044>
Comment 5 WebKit Commit Bot 2016-06-14 09:05:44 PDT
All reviewed patches have been landed.  Closing bug.