WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 158722
Make RenderBlock::insertInto/RemoveFromTrackedRendererMaps functions static.
https://bugs.webkit.org/show_bug.cgi?id=158722
Summary
Make RenderBlock::insertInto/RemoveFromTrackedRendererMaps functions static.
zalan
Reported
2016-06-13 19:59:15 PDT
They manipulate the static tracker maps. No need to have them on RenderBlock.
Attachments
Patch
(10.39 KB, patch)
2016-06-13 20:09 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(10.36 KB, patch)
2016-06-14 08:34 PDT
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2016-06-13 20:09:44 PDT
Created
attachment 281229
[details]
Patch
Simon Fraser (smfr)
Comment 2
2016-06-13 21:07:18 PDT
Comment on
attachment 281229
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=281229&action=review
> Source/WebCore/rendering/RenderBlock.cpp:267 > + HashSet<const RenderBlock*>* containerSet = it->value.get();
Auto?
zalan
Comment 3
2016-06-14 08:34:09 PDT
Created
attachment 281260
[details]
Patch
WebKit Commit Bot
Comment 4
2016-06-14 09:05:40 PDT
Comment on
attachment 281260
[details]
Patch Clearing flags on attachment: 281260 Committed
r202044
: <
http://trac.webkit.org/changeset/202044
>
WebKit Commit Bot
Comment 5
2016-06-14 09:05:44 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug