158704 – FTL::Output methods should be out-of-line whenever possible

Bug 158704 - FTL::Output methods should be out-of-line whenever possible

Summary: FTL::Output methods should be out-of-line whenever possible

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	JavaScriptCore (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Filip Pizlo

URL:
Keywords:

Depends on:
Blocks:

Reported:	2016-06-13 13:56 PDT by Filip Pizlo
Modified:	2016-06-13 15:16 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
the patch (41.40 KB, patch) 2016-06-13 13:59 PDT, Filip Pizlo	benjamin: review+	Details \| Formatted Diff \| Diff
patch for landing (41.93 KB, patch) 2016-06-13 14:38 PDT, Filip Pizlo	no flags	Details \| Formatted Diff \| Diff
even better (41.55 KB, patch) 2016-06-13 14:51 PDT, Filip Pizlo	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Filip Pizlo 2016-06-13 13:56:54 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2016-06-13 13:59:28 PDT

Created attachment 281199 [details]
the patch

Comment 2 WebKit Commit Bot 2016-06-13 14:00:57 PDT

Attachment 281199 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:115:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:150:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:155:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:156:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:162:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:164:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:170:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:171:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:171:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:173:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:175:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:176:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:177:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:326:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:327:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:328:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:329:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:340:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:391:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:395:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:400:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:404:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 23 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Filip Pizlo 2016-06-13 14:38:44 PDT

Created attachment 281204 [details]
patch for landing

Comment 4 WebKit Commit Bot 2016-06-13 14:41:16 PDT

Attachment 281204 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:340:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Filip Pizlo 2016-06-13 14:51:25 PDT

Created attachment 281206 [details]
even better

Removed some more pointless parameter names from FTLOutput.h.  I think that add(Lvalue, LValue) looks better than add(LValue left, LValue right).  I retained the parameter names in cases where they make sense, like shl(LValue, LValue shiftAmount).

Comment 6 WebKit Commit Bot 2016-06-13 14:52:28 PDT

Attachment 281206 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:339:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 7 Filip Pizlo 2016-06-13 15:16:39 PDT

Landed in http://trac.webkit.org/changeset/202007