RESOLVED FIXED 158704
FTL::Output methods should be out-of-line whenever possible 
https://bugs.webkit.org/show_bug.cgi?id=158704
Summary FTL::Output methods should be out-of-line whenever possible
Filip Pizlo
Reported 2016-06-13 13:56:54 PDT
Patch forthcoming.
Attachments
the patch (41.40 KB, patch)
2016-06-13 13:59 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
patch for landing (41.93 KB, patch)
2016-06-13 14:38 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
even better (41.55 KB, patch)
2016-06-13 14:51 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-06-13 13:59:28 PDT
Created attachment 281199 [details] the patch
WebKit Commit Bot
Comment 2 2016-06-13 14:00:57 PDT
Attachment 281199 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:115: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:150: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:155: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:156: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:162: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:164: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:170: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:171: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:171: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:173: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:175: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:176: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:177: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:326: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:327: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:328: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:329: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:340: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:391: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:395: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:400: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:404: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 23 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2016-06-13 14:38:44 PDT
Created attachment 281204 [details] patch for landing
WebKit Commit Bot
Comment 4 2016-06-13 14:41:16 PDT
Attachment 281204 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:340: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 5 2016-06-13 14:51:25 PDT
Created attachment 281206 [details] even better Removed some more pointless parameter names from FTLOutput.h. I think that add(Lvalue, LValue) looks better than add(LValue left, LValue right). I retained the parameter names in cases where they make sense, like shl(LValue, LValue shiftAmount).
WebKit Commit Bot
Comment 6 2016-06-13 14:52:28 PDT
Attachment 281206 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:249: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:339: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 7 2016-06-13 15:16:39 PDT
Landed in http://trac.webkit.org/changeset/202007
Note You need to log in before you can comment on or make changes to this bug.