Bug 158694 - Modern IDB: IDBOpenDBRequest objects leak
Summary: Modern IDB: IDBOpenDBRequest objects leak
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 154015
  Show dependency treegraph
 
Reported: 2016-06-13 09:37 PDT by Brady Eidson
Modified: 2016-06-13 10:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch v1 (1.51 KB, patch)
2016-06-13 09:46 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-06-13 09:37:50 PDT
Modern IDB: IDBOpenDBRequest objects leak

I traced through the various refs/derefs of a particular opendbrequest and noticed it was left hanging with a ref count of 1.

The ref that never gets cleared out is the m_openDBRequestMap of IDBConnectionProxy. The only time anything is ever cleared from that map is when a worker thread is torn down, but it never gets anything removed under main thread use.
Comment 1 Brady Eidson 2016-06-13 09:46:26 PDT
Created attachment 281178 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-06-13 10:31:14 PDT
Comment on attachment 281178 [details]
Patch v1

Clearing flags on attachment: 281178

Committed r201995: <http://trac.webkit.org/changeset/201995>
Comment 3 WebKit Commit Bot 2016-06-13 10:31:17 PDT
All reviewed patches have been landed.  Closing bug.