This causes compilation error on FreeBSD: /home/lantw44/webkit/source/WebKit/Source/WebCore/platform/graphics/PlatformDisplay.cpp:169:5: error: no member named 'atexit' in namespace 'std'; did you mean simply 'atexit'? std::atexit([] { PlatformDisplay::sharedDisplay().terminateEGLDisplay(); }); ^~~~~~~~~~~ atexit /usr/include/stdlib.h:84:6: note: 'atexit' declared here int atexit(void (*)(void)); ^ 1 error generated.
Created attachment 281145 [details] Patch
Attachment 281145 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 281146 [details] Patch
Comment on attachment 281146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281146&action=review > Source/WebCore/platform/graphics/PlatformDisplay.cpp:29 > +#include <cstdlib> Was this causing a build error for you?
Comment on attachment 281146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281146&action=review r=me >> Source/WebCore/platform/graphics/PlatformDisplay.cpp:29 >> +#include <cstdlib> > > Was this causing a build error for you? Oh -- for BSD builds. Ok.
Comment on attachment 281146 [details] Patch Clearing flags on attachment: 281146 Committed r202145: <http://trac.webkit.org/changeset/202145>
All reviewed patches have been landed. Closing bug.