build-testkjs reports grep's exit code instead of xcodebuild (thus never fails!)

[Eric Seidel (no email)]

build-testkjs reports grep's exit code instead of xcodebuild (thus never fails!)

This is the trouble line:

    $result = system "sh", "-c", 'xcodebuild -project JavaScriptCore.xcodeproj -target testkjs "$@" | grep -v setenv', "xcodebuild",  @options, @ARGV;

I'm sure there is some slick way to grab the exit code from the other side of the pipe.  But I'm rather tired and going to cop-out and file this bug instead.

[Eric Seidel (no email)]

Created attachment 17084 [details]
the fix

[Mark Rowe (bdash)]

Comment on attachment 17084 [details]
the fix

The patch claims I have already reviewed this, so here is an r=me in Bugzilla too.

[Eric Seidel (no email)]

Landed as r27497