Bug 158675 - Web Inspector: DataGrid should manage its own settings
Summary: Web Inspector: DataGrid should manage its own settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on: 158676
Blocks: 158767
  Show dependency tree / graph
 
Reported: 2016-06-12 14:01 PDT by Matt Baker
Modified: 2016-06-16 12:39 PDT (History)
7 users (show)

See Also:

Attachments
[Patch] Proposed Fix (22.08 KB, patch)
2016-06-14 17:37 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Patch] For Landing (22.10 KB, patch)
2016-06-15 17:35 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-06-12 14:01:04 PDT 
* SUMMARY
DataGrid should manage its own settings. Code for creating grid settings (for sorting) is repeated in a dozen places. DataGrid needs an "identifier" property, so that each instance will have it's own settings, and a way to handle default setting values.
Comment 1 Radar WebKit Bug Importer 2016-06-12 14:01:57 PDT 
<rdar://problem/26761338>
Comment 2 Matt Baker 2016-06-14 17:37:09 PDT 
Created attachment 281301 [details]
[Patch] Proposed Fix
Comment 3 WebKit Commit Bot 2016-06-15 17:16:28 PDT 
Comment on attachment 281301 [details]
[Patch] Proposed Fix

Rejecting attachment 281301 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 281301, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
kGridContentView.js
patching file Source/WebInspectorUI/UserInterface/Views/NetworkTimelineView.js
patching file Source/WebInspectorUI/UserInterface/Views/ProfileView.js
patching file Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js
patching file Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1509777
Comment 4 Matt Baker 2016-06-15 17:35:47 PDT 
Created attachment 281416 [details]
[Patch] For Landing
Comment 5 WebKit Commit Bot 2016-06-16 12:39:11 PDT 
Comment on attachment 281416 [details]
[Patch] For Landing

Clearing flags on attachment: 281416

Committed r202133: <http://trac.webkit.org/changeset/202133>
Comment 6 WebKit Commit Bot 2016-06-16 12:39:14 PDT 
All reviewed patches have been landed.  Closing bug.