Store .lut.h hashfile keys as UTF16 stings for faster key compares
I've attached a patch which does that, I've not yet perf tested it. (About to do so.)
Created attachment 17077 [details]
Created attachment 17079 [details]
naive fix (0.5% slower according to SunSpider)
Hum.. well, the shark diff makes no sense at all.
spectral-norm: 2.2% *slower* 126.8ms +/- 0.8% 129.6ms +/- 0.9% significant
is the worst regression. four others are more than 1.0% slower. Overall 0.2% slower according to my most recent run.
A good test to try and optimize this with might be string-validate-input.js. I see that test spending 2.4% of total time in findEntry()
I did a fancier version of this optimization recently. I think this bug is probably obsolete.
Eric, is this bug still valid?
Yeah, I think we tried this and it was slower.