Patch forthcoming.
Created attachment 281064 [details] the patch
Created attachment 281066 [details] the patch Made minor fixes.
Comment on attachment 281066 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=281066&action=review r=me with some comments. > PerformanceTests/Air.js/README.md:35 > +more readable. Unlike the original C++ Air, Air.js doesn't take advantage of > +deep understanding of compilers to make the code easy to compile. I think I would phrase this as "Unlike the original C++ Air, Air.js doesn't exploit a deep understanding of compilers to make the code easy to compile." The extra prepositions make the sentence seem clunky. > PerformanceTests/Air.js/README.md:106 > +C++ Air and Air.js, and we assert that for each payload looks identical after "that for each" => each > PerformanceTests/Air.js/README.md:109 > +allcoateStack, to help catch bugs from payload initialization. We have not Nit: from => during
(In reply to comment #3) > Comment on attachment 281066 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=281066&action=review > > r=me with some comments. > > > PerformanceTests/Air.js/README.md:35 > > +more readable. Unlike the original C++ Air, Air.js doesn't take advantage of > > +deep understanding of compilers to make the code easy to compile. > > I think I would phrase this as "Unlike the original C++ Air, Air.js doesn't > exploit a deep understanding of compilers to make the code easy to compile." > The extra prepositions make the sentence seem clunky. Yeah, that's much better. > > > PerformanceTests/Air.js/README.md:106 > > +C++ Air and Air.js, and we assert that for each payload looks identical after > > "that for each" => each Fixed. > > > PerformanceTests/Air.js/README.md:109 > > +allcoateStack, to help catch bugs from payload initialization. We have not > > Nit: from => during Fixed. Thanks for the review!
Landed in http://trac.webkit.org/changeset/201957