Bug 158637 – setUpStaticFunctionSlot does not handle Builtin|Accessor properties

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

setUpStaticFunctionSlot contains a duplicate copy of the body of the function reifyStaticProperty - however it is missing handling for Accessor type under Builtin functions. Fix the bug by de-duplicating – setUpStaticFunctionSlot should just call reifyStaticProperty.

[Gavin Barraclough]

Created attachment 281052 [details]
Fix

[Gavin Barraclough]

Comment on attachment 281052 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281052&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        Fix the bug by de-duplicating â setUpStaticFunctionSlot should just call reifyStaticProperty.

Oops - should be hyphen. Will fix before landing.

[Build Bot]

Comment on attachment 281052 [details]
Fix

Attachment 281052 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1480719

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 281055 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 281052 [details]
Fix

Attachment 281052 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1480733

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 281056 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 281052 [details]
Fix

Attachment 281052 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1480711

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 281057 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 281052 [details]
Fix

Attachment 281052 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1480720

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 281058 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Gavin Barraclough]

Created attachment 281065 [details]
Fix

[Geoffrey Garen]

Comment on attachment 281065 [details]
Fix

r=me

[Gavin Barraclough]

Committed revision 202033.