Bug 158631 - The backend should be happy to compile Unreachable even if AI didn't prove it to be unreachable
Summary: The backend should be happy to compile Unreachable even if AI didn't prove it...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on: 157379
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-10 12:18 PDT by Filip Pizlo
Modified: 2016-06-10 13:56 PDT (History)
12 users (show)

See Also:


Attachments
the patch (6.94 KB, patch)
2016-06-10 12:31 PDT, Filip Pizlo
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-06-10 12:18:53 PDT
It's possible that due to concurrency, we invalidate the compilation after the last run of the CFA phase but before the backend. Then, when AI runs during the backend, it might think that some code that was previously thought to be Unreachable is now reachable.  We shouldn't crash when this happens.
Comment 1 Filip Pizlo 2016-06-10 12:31:37 PDT
Created attachment 281032 [details]
the patch
Comment 2 Keith Miller 2016-06-10 12:52:03 PDT
Comment on attachment 281032 [details]
the patch

r=me.
Comment 3 Filip Pizlo 2016-06-10 12:56:04 PDT
Landed in http://trac.webkit.org/changeset/201936
Comment 4 David Kilzer (:ddkilzer) 2016-06-10 13:56:23 PDT
<rdar://problem/26540392>