Bug 158626 - Web Inspector: 1px gap above timeline progress view
Summary: Web Inspector: 1px gap above timeline progress view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-10 11:33 PDT by Matt Baker
Modified: 2016-06-10 12:41 PDT (History)
8 users (show)

See Also:


Attachments
[Image] 1px gap between nav bar and progress view (125.08 KB, image/png)
2016-06-10 11:33 PDT, Matt Baker
no flags Details
Patch (1.14 KB, patch)
2016-06-10 11:37 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Patch] Proposed Fix (1.48 KB, patch)
2016-06-10 11:40 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-06-10 11:33:29 PDT
Created attachment 281019 [details]
[Image] 1px gap between nav bar and progress view

* SUMMARY
1px gap above timeline progress view (see attachment).

Regressed in http://trac.webkit.org/changeset/201538.
Comment 1 Nikita Vasilyev 2016-06-10 11:37:14 PDT
Created attachment 281021 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-06-10 11:37:41 PDT
<rdar://problem/26744112>
Comment 3 Matt Baker 2016-06-10 11:39:02 PDT
Comment on attachment 281021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281021&action=review

> Source/WebInspectorUI/UserInterface/Views/ProfileView.css:-37
> -

This is already addressed in another patch: https://bugs.webkit.org/show_bug.cgi?id=158624. The correct fix is to adjust the top of the progress view. I have a patch for that.
Comment 4 Matt Baker 2016-06-10 11:40:11 PDT
Created attachment 281022 [details]
[Patch] Proposed Fix
Comment 5 Matt Baker 2016-06-10 11:43:18 PDT
*** Bug 158627 has been marked as a duplicate of this bug. ***
Comment 6 Nikita Vasilyev 2016-06-10 11:46:21 PDT
(In reply to comment #3)
> Comment on attachment 281021 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=281021&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/ProfileView.css:-37
> > -
> 
> This is already addressed in another patch:
> https://bugs.webkit.org/show_bug.cgi?id=158624. The correct fix is to adjust
> the top of the progress view. I have a patch for that.

You're right.

Your patch looks good.
Comment 7 Joseph Pecoraro 2016-06-10 12:18:33 PDT
Comment on attachment 281022 [details]
[Patch] Proposed Fix

r=me
Comment 8 Nikita Vasilyev 2016-06-10 12:26:37 PDT
Comment on attachment 281022 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281022&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.css:-69
> -    top: 30px;

This matches the height of .navigation-bar. We should probably introduce a variable, like
--navigation-bar-height.
Comment 9 WebKit Commit Bot 2016-06-10 12:41:06 PDT
Comment on attachment 281022 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 281022

Committed r201935: <http://trac.webkit.org/changeset/201935>
Comment 10 WebKit Commit Bot 2016-06-10 12:41:09 PDT
All reviewed patches have been landed.  Closing bug.