Bug 158606 – ErrorEvent / ProgressEvent should be exposed to workers

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

ErrorEvent should be exposed to workers:
https://html.spec.whatwg.org/multipage/webappapis.html#errorevent

Test:
http://w3c-test.org/workers/semantics/interface-objects/001.worker

[Chris Dumez]

Created attachment 280992 [details]
Patch

[Alex Christensen]

Comment on attachment 280992 [details]
Patch

Actually, I'm not sure.  ErrorEvent::createForBindings uses an AtomicString, and can't that only be used from the main thread?

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 280992 [details]
> Patch
> 
> Actually, I'm not sure.  ErrorEvent::createForBindings uses an AtomicString,
> and can't that only be used from the main thread?

Using AtomicString in other threads is fine. What you cannot do is pass them to other threads. AtomicStrings are per thread AFAIK.

[Brady Eidson]

(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 280992 [details]
> > Patch
> > 
> > Actually, I'm not sure.  ErrorEvent::createForBindings uses an AtomicString,
> > and can't that only be used from the main thread?
> 
> Using AtomicString in other threads is fine. What you cannot do is pass them
> to other threads. AtomicStrings are per thread AFAIK.

This is correct - Each thread has its own AtomicString table, and its safe to use them within a given thread.

[Chris Dumez]

Comment on attachment 280992 [details]
Patch

Clearing flags on attachment: 280992

Committed r201926: <http://trac.webkit.org/changeset/201926>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.