WorkerNavigator is missing some NavigatorID attributes: https://html.spec.whatwg.org/multipage/workers.html#the-workernavigator-object https://html.spec.whatwg.org/multipage/webappapis.html#navigatorid We should use the same NavigatorID interface for Navigator and WorkerNavigator.
<rdar://problem/26731334>
Created attachment 280978 [details] Patch
Created attachment 280984 [details] Patch
Comment on attachment 280984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280984&action=review > Source/WebCore/page/NavigatorBase.h:35 > + String appName() const; Should be a static member function. Annoying that it makes a new String every time and doesn’t use ASCIILiteral. Same for most of the other functions below. > Source/WebCore/page/NavigatorBase.h:38 > + String platform() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:40 > + String appCodeName() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:41 > + String product() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:42 > + String productSub() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:43 > + String vendor() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:44 > + String vendorSub() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:46 > + bool onLine() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:48 > + String language() const; Should be a static member function. > Source/WebCore/page/NavigatorBase.h:51 > + int hardwareConcurrency() const; Should be a static member function. > Source/WebCore/platform/Language.cpp:115 > + Vector<String> overrideCopy; > + overrideCopy.reserveInitialCapacity(override.size()); > + for (String& language : override) > + overrideCopy.uncheckedAppend(language.isolatedCopy()); > + return overrideCopy; This should be an isolatedCopy function that takes a Vector<String> and returns another Vector<String>, not written in line here like this.
Created attachment 281054 [details] Patch
Created attachment 281060 [details] Patch
Created attachment 281061 [details] Patch
Comment on attachment 281061 [details] Patch Clearing flags on attachment: 281061 Committed r201970: <http://trac.webkit.org/changeset/201970>
All reviewed patches have been landed. Closing bug.